Skip to content

fix: iec-c14 on the DB 700, checksum paths in the release job - #955

Merged
jeffreylouden merged 2 commits into
mainfrom
claude/lucid-lamport-gp8lyw
Oct 17, 2026
Merged

jeffreylouden merged 2 commits into
mainfrom
claude/lucid-lamport-gp8lyw

Conversation

@jeffreylouden

@jeffreylouden jeffreylouden commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Description

Two breakages on main since #952 (AUREO-1483) merged, both found by
reading the last day of workflow runs rather than reported by anything.

Validate is red on main and will be red on every PR. #948
(aguilar) opened before #952 and merged after it, so its PR CI ran under
the advisory W121 and main now runs the strict E130. One port on
aguilar-db-700 carries connection: iec, which the vocabulary does not
hold (it has iec-c6, iec-c8, iec-c14, iec-c20). Retyped to
iec-c14: the DB 700 is a 700 W rack-mount head with "universal mains"
and a detachable cord, which is the standard 10 A C14 inlet on a head of
that class. The entry's prose names no variant, so this is the catalog's
convention rather than a reading off the manual; say so if you would
rather it went to /io-enrich. The other 13 Aguilar power ports are
barrel and validate.

The release job cannot sign. #952 split release.yml so signing
runs in a job that installs nothing, and its verify step did
cd dist && sha256sum -c catalog.sqlite.sha256. Each .sha256 line
names its file as dist/catalog.sqlite, the path the build job hashed
it under, so from inside dist/ sha256sum looked for dist/dist/...
and failed (run 38889150920, the one time build has run since). The
check now runs from the repository root with dist/ paths. The
generation side is unchanged on purpose: the published .sha256 files
are what Studio and the marketing site read. No release was lost (the
tag for 3.72.0 already existed on that commit), but the next version
PR to merge would have failed to publish.

Type of Change

  • New software/plugin entry
  • New hardware entry
  • New manufacturer entry
  • Update to existing entry
  • Bug fix
  • Schema or script change

Checklist

  • I have run pnpm validate and it passes
  • YAML files follow the existing format
  • Manufacturer exists (or I'm adding it in this PR)
  • Categories and formats are from the schema files
  • Identifiers are accurate, if provided (bundle IDs, etc.)
  • Any hp I added or changed names its source in the description

Additional Notes

Refs AUREO-1483. Reproduced the checksum failure and the fix locally
with two stand-in files: the cd dist form reports "1 listed file
could not be read", the root form reports both OK. A patch changeset
covers the port fix, because the changeset check requires one for any
data/ change; the workflow change versions nothing. CI is green on the
head, including the Validate run that was red on main.

🤖 Generated with Claude Code

https://claude.ai/code/session_013X2d8vEWjRnkZydpXo94JF

E130 refused the bare `iec` the aguilar import
wrote, reddening main and every PR since; the
rack head's detachable mains inlet is the C14.
The split release job cd'd into dist/ and then
read checksum lines naming dist/<file>, so the
sign step failed on the first run. Refs AUREO-1483.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013X2d8vEWjRnkZydpXo94JF
@changeset-bot

changeset-bot Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a92a94c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
catalog Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added ci Changes to CI/CD workflows hardware Changes to hardware catalog entries ready-for-review PR has passed all checks and is ready for review labels Oct 17, 2026
@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: existential-engineering/catalog/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 573a8fad-9c0e-4e44-bbdf-40888de5d188
📥 Commits

Reviewing files that changed from the base of the PR and between b0cba2b and 325234c.

📒 Files selected for processing: 2
  • .github/workflows/release.yml
  • data/hardware/aguilar-db-700.yaml

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Walkthrough

The release workflow verifies checksum files from the repository root using paths under dist/. The Aguilar DB 700 Power connection type is now iec-c14.

Changes

Release checksum verification

Layer / File(s) Summary
Checksum verification paths
.github/workflows/release.yml
Checksum verification runs from the repository root and uses paths under dist/. The exact-five-file check and failure behavior are unchanged.

Aguilar DB 700 connection type

Layer / File(s) Summary
Power connection type
data/hardware/aguilar-db-700.yaml
The Power connection type changes from iec to iec-c14.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 32523

No actionable merge-blocking issue is established. The release check and catalog change can proceed with normal validation.

### Architecture Summary

Architecture risk: 🔵 Low · up to 32523

The change affects 1 system.

Changed systems: data

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — data (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in data/hardware/aguilar-db-700.yaml: The Power connection is now specified as iec-c14 instead of iec.
  • observed — Modified behavior in .github/workflows/release.yml: Checksum verification now runs from the repository root using the checksum files’ dist/ paths, instead of changing into dist/ and checking filenames relative to that directory.
Pre-merge checks: Passed 5
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies both main changes: the iec-c14 correction for the DB 700 and the checksum path fix in the release job.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013X2d8vEWjRnkZydpXo94JF
@jeffreylouden
jeffreylouden merged commit 3910d61 into main Oct 17, 2026
12 checks passed
@jeffreylouden
jeffreylouden deleted the claude/lucid-lamport-gp8lyw branch October 17, 2026 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Changes to CI/CD workflows hardware Changes to hardware catalog entries ready-for-review PR has passed all checks and is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants