[jeffreylouden]

Description

Follow-up to #952, from a review that came in after it merged.

The comment above the audit steps says every audit is || true and that "the findings file is uploaded whatever happened". Neither holds for dataset:audit: it has no || true, and Upload findings had no if: always(). So a failed dataset:audit skipped the corpus audits and the upload.

• Upload findings now runs if: always(), so anything written before a failure still reaches the artifact (it already uses if-no-files-found: ignore).
• The comment now says that dataset:audit is deliberately not || true, because the issue update parses its JSON.

The other finding from the same review (release.yml checking checksums from inside dist/) was already fixed on main by #955.

Refs AUREO-1483

Type of Change

• Schema or script change

Checklist

• prettier --check passes on the workflow and it parses as YAML
• No data files touched. No changeset, because this is CI only and should not cut a catalog release.

---

Generated by Claude Code

Summary by CodeRabbit

• Chores
  • Audit findings are now uploaded even when an earlier workflow step fails.
  • Failures in individual corpus audits no longer prevent later audits or the issue update; the dataset audit can still fail the job.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 855766b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: existential-engineering/catalog/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 0a0331dc-3c39-4089-9027-032c4e4582c8

📥 Commits

Reviewing files that changed from the base of the PR and between d1660d8 and 855766b.

📒 Files selected for processing: 1

• .github/workflows/dataset-audit.yml

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Walkthrough

The dataset audit workflow clarifies which audit failures can fail the job. It also runs the findings artifact upload step regardless of earlier step outcomes.

Changes

Dataset audit workflow

Layer / File(s)	Summary
Audit failure handling and findings upload .github/workflows/dataset-audit.yml	Comments describe how corpus-audit failures are tolerated and how dataset:audit failures can fail the job. The findings artifact upload step now uses if: always().

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 85576

The workflow preserves findings already written when a later step fails, while still reporting audit and JSON errors. No concrete merge-blocking risk remains.

### Architecture Summary

Architecture risk: 🔵 Low · up to 85576

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

• observed — Modified behavior in .github/workflows/dataset-audit.yml: The comments now state that corpus-audit failures are tolerated, dataset:audit failures propagate through JSON parsing to fail the job, and the findings upload runs regardless of prior step outcomes. Previously, the comments described only corpus-audit continuation and unconditional upload.
• observed — Modified behavior in .github/workflows/dataset-audit.yml: The findings artifact upload step now has if: always().

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: the dataset-audit workflow now uploads findings even when an earlier step fails.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}