Repository navigation
ci(release): dry run the build on pull requests (AUREO-1483) - #957
Merged
Merged
Conversation
Release runs only on a push to main, so the checksum bug from #952 was first exercised by a real release. The build job moves into a reusable release-build.yml and the artifact check into a composite action; release.yml and a new release-dry-run.yml both call them, so the rehearsal cannot drift from the release. No secrets in the dry run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0142U4PXAPmyuVayPHSAHpqZ
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
release.ymlonly runs on a push tomain, so nothing tests the release path before a real release does. That's how the checksum bug in #952 reachedmain: the splitsign-and-releasejob ransha256sum -cfrom insidedist/against lines namingdist/<file>, and the first release failed (fixed in #955).This PR adds a rehearsal that runs the real steps rather than a copy:
.github/workflows/release-build.yml(new,workflow_call): the release'sbuildjob, moved unchanged. It takes one input,assign-ids, which runspnpm assign-idslocally first, the same wayvalidate.ymldoes. A PR's ids land later throughassign-ids.yml, andpnpm validate/pnpm buildreject an entry without one..github/actions/verify-dist/action.yml(new, composite): the "Verify build output" step, moved unchanged. It's shell only and comes from the same commit as the calling workflow, sosign-and-releasestill installs nothing and runs nothing fromscripts/.release.yml:buildnow callsrelease-build.yml, andsign-and-releaseuses the composite for its check. Job names,needs,if, permissions and the artifact are unchanged, and so is everything after the check (minisign, signing, attestation, release)..github/workflows/release-dry-run.yml(new): on PRs touching the release workflows, the composite,scripts/**or the dependency manifests, it runsrelease-build.yml, then a read-only job that downloads the artifact and runs the same check. It references no secret and stops before minisign.Verification
actionlint1.7.7 is clean onrelease.yml,release-build.ymlandrelease-dry-run.yml.pnpm validate,pnpm buildandpnpm build:indexall pass, and so do the checksums plus the composite's script:dist/catalog.sqlite: OK,dist/catalog-index.json: OK.(cd dist && sha256sum -c ...)line fails withFAILED open or readand exits 1. So this dry run would have caught feat(validate): duplicates, ids, connections and the release job (AUREO-1483) #952's bug on the PR.release.yml, so the dry run runs on it.Type of Change
Checklist
pnpm validatepassesAdditional Notes
The first real test of the
release.ymlchange is the next release after merge. The dry run coversbuildand the artifact check, but not theuses:wiring ofsign-and-release.Refs AUREO-1483
Generated by Claude Code
Summary by CodeRabbit