Add SignalR architecture overview - #69200
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Two documentation inaccuracies should be clarified before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Lite
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
src/SignalR/ARCHITECTURE.md — Scope permissive parsing to implementation behavior |
What changed in this PR
Adds a SignalR architecture overview covering subsystem composition, lifecycle behavior, protocols, transports, clients, and scaleout.
Changes:
- Documents connection, dispatch, reconnect, and failure flows.
- Describes client capabilities and architectural invariants.
- Maps documentation and verification boundaries.
| File | Description |
|---|---|
src/SignalR/ARCHITECTURE.md |
Adds the SignalR architecture and verification overview. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1aed1a9 to
f114156
Compare
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
…ributor-guidance Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep this PR scoped to the SignalR architecture reference doc. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>


Add SignalR architecture overview
Add an in-area SignalR architecture overview for contributors.
Description
Adds
src/SignalR/ARCHITECTURE.md, a reference document for contributors and coding agents working insrc/SignalR. It follows the in-areaARCHITECTURE.mdpattern established by @javiercn in #69147.The content is durable SignalR knowledge extracted from the wider #69011 effort and checked against current code and tests on
main, so SignalR area owners can review and validate it on its own.Documentation only: one new file, no runtime, public API, or other documentation changes.
Validation
git diff --stat origin/main...HEAD: onlysrc/SignalR/ARCHITECTURE.md(275 insertions).git diff --check origin/main...HEADpassed.docs/**/*.md, so it does not cover this in-area document. Runtime tests were not run for this documentation-only change.Related to #69011; this area extraction does not close the wider effort.