Conversation
b8c6a1c to
2fd262f
Compare
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation-only change is fully reviewed, and the remaining diagnostic wording issue is a minor nit that does not block approval.
Review tier: Lite
Findings: None
What changed in this PR
Adds a documentation-only MVC architecture overview covering composition, invocation pipelines, integration boundaries, and verification guidance.
Changes:
- Documents MVC services, descriptors, endpoints, binding, filters, results, and rendering.
- Clarifies ownership boundaries with adjacent subsystems.
- Captures lifetimes, caching, diagnostics, Hot Reload, and trimming considerations.
| File | Review summary |
|---|---|
src/Mvc/ARCHITECTURE.md |
Adds the MVC architecture overview. A minor nit requests distinguishing model-binding logging from DiagnosticListener diagnostics. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
ca9909b to
b252d87
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add MVC architecture overview
Add an in-area MVC architecture reference for contributors and coding agents
Description
Context
This PR extracts durable MVC technical knowledge from the broader #69011 effort into an in-area architecture reference for contributors and coding agents only. MVC area owners can validate and merge the document independently.
The single-file
src/Mvc/ARCHITECTURE.mdshape follows the in-area architecture pattern established by @javiercn in #69147, with the sibling SignalR #69200 and gRPC #69216 extractions as additional examples where useful.Summary
src/Mvc/ARCHITECTURE.mdas an MVC architecture overviewDocumentation only; no runtime or public API changes.
Validation
git diff --checkandgit diff --check origin/main...HEADpassedsrc/Mvc/ARCHITECTURE.md(40 unique targets) resolve on disk; there are no local anchorsgit diff --stat origin/main...HEADshows one new file only:src/Mvc/ARCHITECTURE.md(353 added lines)docs/**/*.md, not this in-area documentRelated to #69011; this extraction does not close the wider effort.