Conversation
PureWeen
changed the title
PureWeen
force-pushed
the
shneuvil-hosting-architecture
branch
from
September 14, 2026 15:22
d2f1011 to
50c6029
Compare
PureWeen
marked this pull request as ready for review
September 14, 2026 15:22
PureWeen
requested
a lite review from Copilot
and removed request for
Copilot
September 14, 2026 15:22
This was referenced Sep 14, 2026
Contributor
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
dotnet-policy-service
Bot
added
the
pending-ci-rerun
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
PureWeen
force-pushed
the
shneuvil-hosting-architecture
branch
from
October 1, 2026 21:01
50c6029 to
709441a
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The only finding is a non-blocking documentation link nit.
Review effort: Lite
Findings: None
What changed in this PR
Adds a Hosting architecture overview and links it as orientation-only reviewer context.
Changes:
- Documents Hosting models, boundaries, lifecycle, diagnostics, and verification.
- Adds the Hosting overview to cross-cutting guidance.
| File | Description |
|---|---|
src/Hosting/ARCHITECTURE.md |
New Hosting architecture documentation; one minor link correction noted. |
docs/CrossCuttingGuidance.md |
Adds the orientation-only Hosting overview link. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Hosting integration architecture overview
Add an in-area Hosting architecture reference.
Description
Add
src/Hosting/ARCHITECTURE.mdas an architecture reference for contributors and coding agents working across ASP.NET Core Hosting andsrc/DefaultBuilder.The document describes the modern, Generic Host integration, and legacy Web Host models; builder and provider phases; Startup and middleware construction; server and lifetime boundaries; diagnostics; extensibility; and verification boundaries. It explicitly keeps the general-purpose Generic Host and dependency-injection container implementations under dotnet/runtime ownership.
This follows the in-area
ARCHITECTURE.mdpattern established by #69147. The change adds one new file only and does not modify production code, public APIs, dependencies, generated files, or repository instructions.Validation
git diff --check origin/main...HEAD- passedRelated to #69011.