Repository navigation
fix(linstor-migrate): report an unreadable layer stack - #226
Open
Andrei Kvapil (kvaps) wants to merge 1 commit into
Open
Andrei Kvapil (kvaps) wants to merge 1 commit into
Andrei Kvapil (kvaps) wants to merge 1 commit into
Conversation
Andrei Kvapil (kvaps)
marked this pull request as ready for review
November 2, 2026 21:31
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 10 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 2, 2026
The stack check read the RD row's layer_stack without looking at the parse error, so an unreadable column counted as no stack. When the replicas then refused the definition, the warning said it had "no layer stack of its own" and the value was never shown; when they agreed, the only trace was a generic "unparsable list dropped". The refusal now names the unreadable value, and a definition that converts says which stack it took from its replicas, or that it has none to take. Either way it is reported once. The site's migration page still described the warnings from before the refusal; it now lists the refusal and this warning. Assisted-by: LLM Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
Andrei Kvapil (kvaps)
force-pushed
the
fix/migrate-report-broken-layer-stack
branch
from
November 2, 2026 22:20
2ae3f07 to
ea5433b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #223. The stack check read the RD row's
layer_stackand ignored the parse error, so a column that is not a JSON list counted as no stack at all.When the replicas then refused the definition, the warning said it had "no layer stack of its own", and the value itself never showed up. When the replicas agreed, the only trace was the generic
unparsable list ... dropped, with nothing about which stack the definition got.Now:
an unreadable layer_stack "[\"DRBD\"," and its replicas were built as ...;Each path reports it once.
I did not make an unreadable column refuse on its own. With every diskful replica chained and all chains agreeing, the chains are what is on disk, and that is the same evidence #223 already trusts for an empty column. Taking them means the satellite adopts each volume as it was built. Anything weaker (replicas built two ways, a replica without a chain) is refused as before, now with the right reason.
The site's migration page still described the stack warnings from before #223 ("left unset; set spec.layerStack before adopting"). It now lists the refusal and the new warning. docs/linstor-migration.md gets one sentence.
Tests:
TestAnUnreadableRDStackIsReportedOncecovers agreeing replicas, disagreeing ones, a replica without a chain and no replicas. Reverting each part of the fix turns its case red.