refactor!: default rerank deps and pass request options as a literal - #10
Merged
TheGreatAxios merged 2 commits intoSep 27, 2026
Conversation
This was referenced Sep 25, 2026
TheGreatAxios
commented
Sep 25, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Contributor
Author
There was a problem hiding this comment.
Self-review: diff checked against ticket outcomes; independent critique pass run, findings on README wording, registry example and CONTRIBUTING commands fixed. Typecheck, tests, prettier and build pass.
TheGreatAxios
force-pushed
the
cl-9155-reranking-replace-spread-built-request-options-with-explicit
branch
from
September 25, 2026 14:16
6db1faf to
88fa537
Compare
TheGreatAxios
force-pushed
the
cl-9155-reranking-replace-spread-built-request-options-with-explicit
branch
from
September 25, 2026 17:31
88fa537 to
8932606
Compare
TheGreatAxios
changed the title
TheGreatAxios
force-pushed
the
cl-9155-reranking-replace-spread-built-request-options-with-explicit
branch
from
September 26, 2026 01:30
8932606 to
ca4392c
Compare
rerankDocuments takes options as optional, defaulting deps to global fetch and createDefaultScheduler(). Request options are passed as one explicit literal instead of conditional spreads. The rerankAdapters record is no longer exported; createRerankAdapterRegistry and rerankAdapterRegistry remain.
TheGreatAxios
force-pushed
the
cl-9155-reranking-replace-spread-built-request-options-with-explicit
branch
from
September 26, 2026 01:30
ca4392c to
6840b90
Compare
TheGreatAxios
changed the title
TheGreatAxios
added this pull request to stack #15
September 26, 2026 01:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rerankDocuments(query, docs, config)works without options.deps(globalfetch+createDefaultScheduler()), registry, retry policy, a 30 s per-attempt timeout and the Retry-After extractor are resolved once inrerankDocuments.src/rerank.ts.rerankAdaptersrecord is no longer exported;createRerankAdapterRegistryandrerankAdapterRegistryremain.RerankConfig.baseUrldoc uses TEI's port 8080.Verification
bun install --frozen-lockfile,bunx tsc --noEmit,bun test ./src,bunx prettier --check .,bun run buildpass.Closes CL-9155
Closes CL-9142
Closes CL-9150