Docs on Workers Builds - #32438
Open
ericclemmons wants to merge 3 commits into
Open
Conversation
ericclemmons
commented
Jul 30, 2026
ericclemmons
force-pushed
the
production
branch
from
August 5, 2026 20:39
124a638 to
bb08608
Compare
Contributor
Review
👉 Fix in your agent 👈Fix the following review findings in PR #32438 (https://github.com/cloudflare/cloudflare-docs/pull/32438).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Warnings (1)
#### CR-a3a4452c5421 · Overly broad minimumReleaseAgeExclude wildcard
- **File:** `pnpm-workspace.yaml` line 18
- **Issue:** minimumReleaseAgeExclude: '@rolldown/*' exempts every package in the @rolldown scope from the 24-hour release-age guard, not just the patched version or its required native binaries. The guard at the top of the file exists to 'reduce risk from newly-published compromised packages.'
- **Fix:** Replace the wildcard with the specific @rolldown native binding packages actually installed (e.g., @rolldown/binding-* patterns or explicit platform packages), or add a comment justifying why the entire scope is acceptable.
### Suggestions (1)
#### CR-c6e4d253085e · Branch-specific comment in production config
- **File:** `pnpm-workspace.yaml` line 16
- **Issue:** The comment says 'Rolldown 1.2.3 contains the native memory fix tested by this branch,' tying the override to the current branch rather than a stable reason for the pin.
- **Fix:** Reword the comment to explain the memory fix and why this version must be pinned for the docs site build, removing the temporary 'tested by this branch' wording before merging.
---
## Conventions
### Warnings (1)
#### CV-c56aca14b856 · PR title format
- **File:** PR-level finding
- **Issue:** The title "Docs on Workers Builds" suggests this PR adds documentation content about Workers Builds, but the changed files are build configuration files (astro.config.ts, package.json, pnpm-lock.yaml, pnpm-workspace.yaml) with no src/content/docs/ changes.
- **Fix:** Update the title to indicate this is a build/configuration change (e.g. "Configure build for Workers Builds" or "Build: switch image service and cache for Workers Builds").
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Warnings (1)
Suggestions (1)
ConventionsWarnings (1)
Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This repo times out at 30 minutes on Workers Builds due to issues with 8 GB of memory (vs. GitHub's 16 GB).
Until that's resolved, there are a few fixes that I found were able to get ~11m builds:
fix: reduce finalization memory usage rolldown/rolldown#10554 is the root issue, causing memory pressure ~5 minutes in and hanging until the timeout at 30 minutes.
Switch to Cloudflare Images (to avoid spending 20+ minutes on Sharp image compression at build time)
https://docs.astro.build/en/guides/integrations-guide/cloudflare/#imageservice
(If this isn't desirable, commit hook or CI job to do this optimistically instead of every single build?)
Revert fix: move Astro cache outside node_modules #31192, because Workers Builds expects the default cache location at
node_modules/.astroAdd this repo to Workers Builds on the Cloudflare Docs' account
Add
GITHUB_TOKENsecret to prevent MDX errors that call the GitHub API:Validate Cloudflare Images works as a replacement to
sharp(which reduced both build times & memory)Validate Astro Cache in
node_modules/.astrodoesn't regress. (Workers Builds cache dependencies based on lockfile and caches the framework, restoring them in that order. So in theory, even if dependencies don't change, each build will re-cache the framework)Screenshots (optional)
Before
After (cold cache)
After (warm cache)
Documentation checklist