-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Docs on Workers Builds #32438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ericclemmons
wants to merge
14
commits into
cloudflare:production
Choose a base branch
from
ericclemmons:production
base: production
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Docs on Workers Builds #32438
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
bb08608
chore: use released Rolldown memory fix
ericclemmons 9fe72ee
chore: keep upstream Vite version
ericclemmons 17c013c
fix: use Astro default cache directory
ericclemmons e60bed1
feat: enable incremental Astro builds
ericclemmons c0acbda
chore: sync upstream with incremental builds disabled
ericclemmons 10f578d
fix: allow required dependency build scripts
ericclemmons 029f792
feat: enable incremental Astro builds
ericclemmons 2656d90
test: use Astro graph hashing preview
ericclemmons c308580
fix: skip unused native postinstall scripts
ericclemmons 8ae1b04
test: verify incremental build cache
ericclemmons db16dac
fix: use default pnpm build script policy
ericclemmons a537543
chore: trigger incremental build test
ericclemmons 9300683
fix: patch unstable astro-icon metadata
ericclemmons 997654b
chore: test patched incremental cache
ericclemmons File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| diff --git a/dist/loaders/loadLocalCollection.js b/dist/loaders/loadLocalCollection.js | ||
| index 2d8e1d4f32ea05b73080eb1f483ad2dc14dbd488..e0d6203ddf1d62a3ab85797441e10ecf9d4bc5a3 100644 | ||
| --- a/dist/loaders/loadLocalCollection.js | ||
| +++ b/dist/loaders/loadLocalCollection.js | ||
| @@ -41,7 +41,9 @@ export default async function createLocalCollection(dir, options = { plugins: [" | ||
| // Update icon | ||
| local.fromSVG(name, svg); | ||
| }); | ||
| - return local.export(true); | ||
| + const collection = local.export(true); | ||
| + delete collection.lastModified; | ||
| + return collection; | ||
| } | ||
| async function convertToCurrentColor(svg) { | ||
| await parseColors(svg, { | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required because
\0virtual:astro-iconuses alastModifiedfrom when the collection is generated.This clears the cacheKey on every single build.
By removing this, the
local.iconsobject is used instead with deep-equality for computing the hash.That's stable between builds. (This is used on ~50 pages, so we don't want this 1 package to prevent restoring 6,846!)