Docs on Workers Builds - #32554
Conversation
Review
👉 Fix in your agent 👈Fix the following review findings in PR #32554 (https://github.com/cloudflare/cloudflare-docs/pull/32554).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Conventions
### Warnings (1)
#### CV-df71e2b2b374 · Scope accuracy
- **File:** PR-level finding
- **Issue:** The description describes build configuration and dependency changes, but does not mention the modifications to worker/index.ts and worker/index.preview.ts (20 total added lines).
- **Fix:** Add an explanation of the changes to worker/index.ts and worker/index.preview.ts so reviewers understand how they relate to the Workers Builds setup.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsWarnings (1)
Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
Preview URL: https://0956a939.preview.developers.cloudflare.com |
|
Skipping CR-453e5fe5f2e4 as originally filed — the |
|
Correction to my previous comment: CR-453e5fe5f2e4 is being addressed — the |
…ReleaseAgeExclude
Summary
This repo times out at 30 minutes on Workers Builds due to issues with 8 GB of memory (vs. GitHub's 16 GB).
Until that's resolved, there are a few fixes that I found were able to get ~11m builds:
fix: reduce finalization memory usage rolldown/rolldown#10554 is the root issue, causing memory pressure ~5 minutes in and hanging until the timeout at 30 minutes.
Switch to Cloudflare Images (to avoid spending 20+ minutes on Sharp image compression at build time)
https://docs.astro.build/en/guides/integrations-guide/cloudflare/#imageservice
(If this isn't desirable, commit hook or CI job to do this optimistically instead of every single build?)
(Won't do) Revert fix: move Astro cache outside node_modules #31192, because Workers Builds expects the default cache location at
node_modules/.astroAdd this repo to Workers Builds on the Cloudflare Docs' account
Add
GITHUB_TOKENsecret to prevent MDX errors that call the GitHub API:Validate Cloudflare Images works as a replacement to
sharp(which reduced both build times & memory)Validate Astro Cache in
node_modules/.astrodoesn't regress. (Workers Builds cache dependencies based on lockfile and caches the framework, restoring them in that order. So in theory, even if dependencies don't change, each build will re-cache the framework)Screenshots (optional)
Before
After (cold cache)
After (warm cache)
Documentation checklist