Repository navigation
Accept numeric IDs in push messages - #1
Merged
Merged
Conversation
This was referenced Oct 26, 2026
|
Tested live via beeper/groupme#25 on a self-hosted bridge, GroupMe messages with mentions now come through where main dropped them entirely. LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messages that mention someone often never arrive over push. GroupMe's web client sends mention
user_idsas numbers and GroupMe relays them unchanged, butIDonly unmarshals strings. Decoding the whole push message fails, and the handler drops it without logging anything:IDnow also accepts JSON numbers. If a push message still can't be decoded, the error goes to the handlers'HandleErrorso it shows up in logs.Changelog: Fixed GroupMe messages with mentions sometimes not arriving.
Before / after
I haven't tested this on a live account yet; it needs a bridge build with this version. Decoding a mention attachment with a numeric
user_idsentry fails with the error above before this change and decodes to the ID after it.Tag
@indentto continue the conversation here.