Repository navigation
Show incoming typing for five seconds from receipt - #28
Merged
Merged
Conversation
Contributor
|
No issues found.
All CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
Contributor
|
Tested live on a self-hosted bridge (main vs this branch), confirmed working: typing from the other side shows within ~0.3s and clears 5s after the last pulse in both groups and DMs, and our own typing is still ignored. Couldn't repro the drop on main though - typing showed fine there too, so whatever hit staging is either clock skew or the push ID issue fixed in beeper/groupme-lib#1 (now merged). LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing from GroupMe never shows in Beeper. Over five hours of staging logs with active chats, the bridge didn't queue a single typing event.
We set the typing timeout from the sender's
startedtimestamp, read as Unix milliseconds, and drop the pulse once that time plus 5 s has passed:That ties delivery to the sending device's clock and to the unit of
started. Ifstartedis in seconds, or the clock is off by more than a few seconds, every pulse counts as expired. GroupMe's web client ignoresstartedand shows typing for 5 s from when the pulse arrives. This change does the same.The existing "expired" test case now expects an old pulse to be delivered.
The logs don't show which of the two causes is happening here. beeper/groupme-lib#1 covers the other way a pulse can disappear.
Changelog: Fixed typing indicators from GroupMe not showing.
Before / after
I haven't run this on a device yet; it needs a staging bridge build.
Tag
@indentto continue the conversation here.