Skip to content

Bridge mentions in both directions - #25

Merged
Fizzadar merged 5 commits into
mainfrom
iFixRobots/mentions
Oct 27, 2026
Merged

Fizzadar merged 5 commits into
mainfrom
iFixRobots/mentions

Conversation

@iFixRobots

@iFixRobots iFixRobots commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Mentions don't work in either direction. Beeper doesn't offer mention suggestions in GroupMe chats, a typed pill reaches GroupMe as plain text that doesn't notify anyone, and mentions from GroupMe show up as plain "@name" text. The room capabilities don't include user links. Outbound pills get flattened by the HTML parser, and inbound conversion skips the attachment:

// Mentions and custom emoji retain their plaintext fallback.

Outbound pills now become a GroupMe mentions attachment with UTF-16 loci, for messages, captions and edits. Inbound loci become Matrix pills with m.mentions, so a mention notifies the Beeper user. The capabilities advertise user_link.

This also bumps groupme-lib to include beeper/groupme-lib#1. Without it, push messages with web-client mentions are dropped before they reach the connector.

Before After
Mention from Beeper No suggestions, plain text Real GroupMe mention
Mention from GroupMe "@name" text, often missing Pill that notifies

Changelog: Added GroupMe mentions.

Before / after

I haven't run this on a device yet; it needs a staging bridge build.

View in Indent
Tag @indent to continue the conversation here.

@indent

indent Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Issues

No issues found.

CI Checks

All CI checks passed on 3144bc6.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)
  • Indent Review Agent · No issues found in the mention bridging
Full results

Indent Review Agent

  • Summary: No issues found in the mention bridging
  • Last ran on commit: 3144bc68
  • Latest result
    {
      "summary": "No issues found in the mention bridging",
      "findings": []
    }

@indent indent Bot added the to be tested label Oct 26, 2026
@Fizzadar

Copy link
Copy Markdown
Contributor

Tested live on a self-hosted bridge (main vs this branch, retested at 3144bc6 after main was merged in), confirmed working:

  • pills from Beeper become real GroupMe mentions for text, image captions and edits, loci spot on with an emoji in front
  • mentions from GroupMe come through as pills with m.mentions, including in an image caption - on main these messages never made it to Beeper at all (the numeric push ID fix in Accept numeric IDs in push messages groupme-lib#1)
  • user_link in room features

GroupMe web trims leading spaces itself so the leading-text offset fix only has a local before/after, not a live one. LGTM!

@Fizzadar
Fizzadar merged commit a63bcd8 into main Oct 27, 2026
5 checks passed
@Fizzadar
Fizzadar deleted the iFixRobots/mentions branch October 27, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants