Repository navigation
Bridge mentions in both directions - #25
Merged
Merged
Conversation
Contributor
|
No issues found.
All CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
# Conflicts: # pkg/connector/capabilities.go # pkg/connector/handlegroupme.go
Contributor
|
Tested live on a self-hosted bridge (main vs this branch, retested at
GroupMe web trims leading spaces itself so the leading-text offset fix only has a local before/after, not a live one. LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mentions don't work in either direction. Beeper doesn't offer mention suggestions in GroupMe chats, a typed pill reaches GroupMe as plain text that doesn't notify anyone, and mentions from GroupMe show up as plain "@name" text. The room capabilities don't include user links. Outbound pills get flattened by the HTML parser, and inbound conversion skips the attachment:
// Mentions and custom emoji retain their plaintext fallback.Outbound pills now become a GroupMe
mentionsattachment with UTF-16loci, for messages, captions and edits. Inboundlocibecome Matrix pills withm.mentions, so a mention notifies the Beeper user. The capabilities advertiseuser_link.This also bumps groupme-lib to include beeper/groupme-lib#1. Without it, push messages with web-client mentions are dropped before they reach the connector.
Changelog: Added GroupMe mentions.
Before / after
I haven't run this on a device yet; it needs a staging bridge build.
Tag
@indentto continue the conversation here.