refactor(APP-1339): Move the ChangeSettings action view from gov-ui-kit to the app

[milosh86]

Description

Moves the proposal detail view for plugin settings changes out of gov-ui-kit and into the app. Follows #1433 (WithdrawToken), #1489 (UpdateMetadata) and #1492 (TokenMint).

Stacked on #1492: this PR targets app-1340-migrate-tokenmint-action. Change the base to main once #1492 is merged (GitHub does it automatically if that branch is deleted on merge).

Unlike the previous migrations, the view cannot read the raw action: each plugin needs DAO data to build the settings rows (multisig the member count, token and lock-to-vote the plugin token, all of them translations). The plugins therefore keep their conversion, and only its output and view move to the app.

App

• New IProposalActionChangeSettings in the governance domain (proposedSettings / existingSettings as term/definition lists) with an app-only type ProposalActionType.CHANGE_SETTINGS = 'CHANGE_SETTINGS'. The backend never sends it, and its PascalCase types cannot collide with it.
• The multisig, token and lock-to-vote normalizeChangeSettingsAction now return that type instead of the kit's CHANGE_SETTINGS_MULTISIG / CHANGE_SETTINGS_TOKENVOTE. Their action types extend the app's IProposalAction instead of the kit type.
• New ChangeSettingsActionDetails in apps/app/src/actions/core/changeSettings/, registered for CHANGE_SETTINGS. It renders the same toggle and definition list as the kit view, and keeps the current side selected when its toggle is clicked again. Copy moved to app.actions.core.changeSettingsActionDetails.*.
• Unchanged: when a hook cannot resolve the target plugin, the action keeps its own type and still renders as raw calldata. Cross-chain forwarded settings changes are not converted, as before.

gov-ui-kit (breaking, major changeset)

• Removed ProposalActionChangeSettings, IProposalActionChangeSettings / IProposalActionChangeSettingsProps, generateProposalActionChangeSettings, ProposalActionType.CHANGE_SETTINGS_MULTISIG / CHANGE_SETTINGS_TOKENVOTE, isChangeSettingsAction with its branch in ProposalActionsItemBasicView, and the proposalActionsChangeSettings modules copy. DefinitionList and IDefinitionSetting are still exported.
• The ProposalActions.Root story now shows a remove-members action.
• Regenerated the component registry and selection guide.

Tests

• Ported the kit view tests (proposed by default, toggle to existing, all rows of each side). Added cases for the toggle labels, clicking the selected toggle again, and empty lists.
• New unit tests for the three normalizeChangeSettingsAction, which had none. They check the output type, that other action fields are kept, and what is passed to parseSettings: the existing settings, then the proposed settings merged over them, plus the member count (multisig) or plugin token (token, lock-to-vote).

Changesets: @aragon/gov-ui-kit major and @aragon/app patch, one changeset per release scope.

Type of Change

• Major: Breaking change (change that would cause existing functionality to not work as expected)
• Patch: Enhancement (non-breaking change to an existing feature)

Developer Checklist:

• Manually smoke tested the functionality in a preview or locally
• Confirmed there are no new warnings or errors in the browser console
• (For User Stories only) Double-checked that all Acceptance Criteria are satisfied
• Confirmed there are no new warnings on automated tests
• Merged and published any dependent changes in downstream modules
• Selected the correct base branch
• Commented the code in hard-to-understand areas
• Followed the code style guidelines of this project
• Reviewed that the Files Changed in Github’s UI reflect my intended changes
• Confirmed the pipeline checks are not failing

Review Checklist:

• (For User Stories only) Tested in a preview or locally that all Acceptance Criteria are satisfied
• Confirmed that changes follow the code style guidelines of this project

[linear-code]

APP-1339

[github-actions]

🚀 Preview Deployment: View Here

[github-actions]

E2E results (preview)

Smoke

Base URL	https://app-next-jjzob08i3-aragon-app.vercel.app
Suite	smoke
Playwright result	✅ passed
Summary	86 passed
HTML report	View report
GitHub job	✅ completed

View run #5565

[thekidnamedkd]

LGTM 🧲