Skip to content

refactor(APP-1340): Move the TokenMint action view from gov-ui-kit to the app - #1492

Merged
milosh86 merged 6 commits into
mainfrom
app-1340-migrate-tokenmint-action
Oct 16, 2026
Merged

milosh86 merged 6 commits into
mainfrom
app-1340-migrate-tokenmint-action

Conversation

@milosh86

@milosh86 milosh86 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Description

Moves the proposal detail view for token mint actions out of gov-ui-kit and into the app. Follows the same approach as #1433 (WithdrawToken) and #1489 (UpdateMetadata).

Includes the stacked PRs merged into this branch:

App

  • New TokenMintActionDetails in apps/app/src/actions/token/, registered in the action view registry under the token plugin's Mint action type through initTokenActionViews. It renders the kit's MemberDataListItemStructure, shows the receiver's ENS name when they have one, and links the receiver to the block explorer through useDaoChain.
  • The minted amount is computed from the raw balances before they are formatted (formatUnits(BigInt(newBalance) - BigInt(currentBalance), decimals)). The kit view subtracted the already-formatted balances as JS numbers. The displayed value is unchanged in practice, because MemberDataListItemStructure still shortens the amount.
  • ITokenActionTokenMint now extends the app's IProposalAction instead of the kit type. It drops the inherited tokenSymbol the backend never sent and adds the optional receiver ens.
  • Removed tokenActionUtils.normalizeTokenMintAction / isTokenMintAction and the mint branch in useTokenNormalizeActions. Mint actions now pass through unchanged and the view reads them directly.
  • New generateTokenActionTokenMint test generator in the token plugin test utils.
  • Cross-chain forwarded mints keep rendering as raw calldata, as before.

gov-ui-kit (breaking, major changeset)

  • Removed ProposalActionTokenMint, IProposalActionTokenMint / IProposalActionTokenMintMetadataReceiver / IProposalActionTokenMintProps, generateProposalActionTokenMint, ProposalActionType.TOKEN_MINT, isTokenMintAction with its branch in ProposalActionsItemBasicView, and the unused proposalActionsTokenMint modules copy. MemberDataListItemStructure is still exported.
  • The ProposalActionsItem "Native" story now uses a ChangeMembers action.
  • Regenerated the component registry and selection guide.

Tests

  • Ported the kit tests: receiver, token symbol, hidden voting-power label, block-explorer link, plus a render with the real member item and an ENS-named receiver.
  • initTokenActionViews tests check that the view is registered by action type only, with no selector, create component, composer item or permission. Integration tests render the registered view through ProposalActionsItem and the cross-chain nested actions list.
  • Table of minted-amount cases with exact expected values, including three the previous float subtraction got wrong: 1 unit of a 6-decimals token, an amount beyond the safe integer range, and 1 wei on top of a large balance. Putting the old arithmetic back fails exactly those three.

Changesets: @aragon/gov-ui-kit major and @aragon/app patch, one changeset per release scope (plus the ones from #1493 and #1494).

Type of Change

  • Major: Breaking change (change that would cause existing functionality to not work as expected)
  • Patch: Enhancement (non-breaking change to an existing feature)

Developer Checklist:

  • Manually smoke tested the functionality in a preview or locally
  • Confirmed there are no new warnings or errors in the browser console
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisfied
  • Confirmed there are no new warnings on automated tests
  • Merged and published any dependent changes in downstream modules
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the Files Changed in Github’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • (For User Stories only) Tested in a preview or locally that all Acceptance Criteria are satisfied
  • Confirmed that changes follow the code style guidelines of this project

Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
@linear-code

linear-code Bot commented Oct 14, 2026

Copy link
Copy Markdown

APP-1340

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

🚀 Preview Deployment: View Here

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

E2E results (preview)

Smoke

Base URL https://app-next-r4c3v3jlk-aragon-app.vercel.app
Suite smoke
Playwright result ✅ passed
Summary 86 passed
HTML report View report
GitHub job ✅ completed

View run #5567

Signed-off-by: Milos Dzepina <milos@aragon.org>
Comment thread packages/gov-ui-kit/design-system/component-registry/registry.json Outdated
…it to the app (#1493)

* refactor(APP-1338): Move the ChangeMembers action view to the app and drop the kit's built-in action views (#1494)

Signed-off-by: Milos Dzepina <milos@aragon.org>

---------

Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>

@thekidnamedkd thekidnamedkd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧭

@milosh86
milosh86 merged commit 07b1292 into main Oct 16, 2026
23 checks passed
@milosh86
milosh86 deleted the app-1340-migrate-tokenmint-action branch October 16, 2026 15:14

This branch was successfully deployed

1 active deployment
preview — 3b989d6e Deployed Oct 15, 2026 by milosh86 via deploy / deploy #5567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants