Repository navigation
refactor(APP-1340): Move the TokenMint action view from gov-ui-kit to the app - #1492
Merged
Merged
Conversation
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
|
🚀 Preview Deployment: View Here |
|
E2E results (preview) Smoke
|
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
thekidnamedkd
approved these changes
Oct 16, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the proposal detail view for token mint actions out of gov-ui-kit and into the app. Follows the same approach as #1433 (WithdrawToken) and #1489 (UpdateMetadata).
Includes the stacked PRs merged into this branch:
App
TokenMintActionDetailsinapps/app/src/actions/token/, registered in the action view registry under the token plugin'sMintaction type throughinitTokenActionViews. It renders the kit'sMemberDataListItemStructure, shows the receiver's ENS name when they have one, and links the receiver to the block explorer throughuseDaoChain.formatUnits(BigInt(newBalance) - BigInt(currentBalance), decimals)). The kit view subtracted the already-formatted balances as JS numbers. The displayed value is unchanged in practice, becauseMemberDataListItemStructurestill shortens the amount.ITokenActionTokenMintnow extends the app'sIProposalActioninstead of the kit type. It drops the inheritedtokenSymbolthe backend never sent and adds the optional receiverens.tokenActionUtils.normalizeTokenMintAction/isTokenMintActionand the mint branch inuseTokenNormalizeActions. Mint actions now pass through unchanged and the view reads them directly.generateTokenActionTokenMinttest generator in the token plugin test utils.gov-ui-kit (breaking, major changeset)
ProposalActionTokenMint,IProposalActionTokenMint/IProposalActionTokenMintMetadataReceiver/IProposalActionTokenMintProps,generateProposalActionTokenMint,ProposalActionType.TOKEN_MINT,isTokenMintActionwith its branch inProposalActionsItemBasicView, and the unusedproposalActionsTokenMintmodules copy.MemberDataListItemStructureis still exported.ProposalActionsItem"Native" story now uses a ChangeMembers action.Tests
initTokenActionViewstests check that the view is registered by action type only, with no selector, create component, composer item or permission. Integration tests render the registered view throughProposalActionsItemand the cross-chain nested actions list.Changesets:
@aragon/gov-ui-kitmajor and@aragon/apppatch, one changeset per release scope (plus the ones from #1493 and #1494).Type of Change
Developer Checklist:
Review Checklist: