Repository navigation
refactor(APP-1338): Move the ChangeMembers action view to the app and drop the kit's built-in action views - #1494
Merged
milosh86 merged 2 commits intoOct 15, 2026
Conversation
Signed-off-by: Milos Dzepina <milos@aragon.org>
|
🚀 Preview Deployment: View Here |
|
E2E results (preview) Smoke
|
Signed-off-by: Milos Dzepina <milos@aragon.org>
milosh86
merged commit Oct 15, 2026
70d9879
into
app-1339-migrate-changesettings-action
13 checks passed
5 of 14 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the last gov-ui-kit proposal action view, ChangeMembers, into the app, and removes the kit's built-in action-view machinery now that nothing is left behind it. Follows #1433 (WithdrawToken), #1489 (UpdateMetadata), #1492 (TokenMint) and #1493 (ChangeSettings).
App
MultisigChangeMembersActionDetailsinapps/app/src/actions/multisig/, registered in the action view registry forMultisigAddMembersandMultisigRemoveMembersthroughinitMultisigActionViews. It renders a member item per added or removed member (ENS name when available, block-explorer link throughuseDaoChain), plus the added/removed count, the existing member count and the block note. Copy moved toapp.actions.multisig.multisigChangeMembersActionDetails.*.membersandcurrentMembersalready come from the backend. RemovedmultisigActionUtils.normalizeChangeMembersAction/isChangeMembersActionand their branch inuseMultisigNormalizeActions, which only renamed the type to the kit'sADD_MEMBERS/REMOVE_MEMBERS.IMultisigActionChangeMembersnow extends the app'sIProposalActioninstead of the kit type. NewgenerateMultisigActionChangeMemberstest generator.gov-ui-kit (breaking, major changeset)
ProposalActionChangeMembers,IProposalActionChangeMembers/IProposalActionChangeMembersProps,generateProposalActionChangeMembersand theproposalActionChangeMembersmodules copy.proposalActionsListmodule,ProposalActionsItemBasicView,proposalActionsItemUtils(isActionSupported,isChangeMembersAction) and the now-emptyProposalActionTypeenum.ProposalActions.ItemrendersCustomComponentdirectly as its BASIC view. Without one, the BASIC view mode is disabled and the item opens the decoded or raw view.ProposalActionTypeNoBasicViewstays exported.ProposalActions.Item"Native" story is replaced by a "CustomView" story that passes aCustomComponent. TheProposalActions.Rootstories use generic decoded actions.ProposalActionsusage notes and comments, and regenerated the component registry and selection guide.Tests
ProposalActions.Itemtests:CustomComponentreceives the action, index, chain id and web3 props, the BASIC view is disabled without it, and the tests that fakedisActionSupportednow pass a realCustomComponent.useMultisigNormalizeActionsnow asserts members actions pass through unchanged.Changesets:
@aragon/gov-ui-kitmajor and@aragon/apppatch, one changeset per release scope.Type of Change
Developer Checklist:
Review Checklist: