Repository navigation
Conversation
github-actions
Bot
added
releases-note/fix
YuangGao
force-pushed
the
fix/azfile-os-env-credentials
branch
from
October 29, 2026 02:10
c5c6def to
f8c25f9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-up to #8395.
Rationale for this change
azfile handed reqsign a
StaticEnvbuilt only from config values, so credentials in the process environment never reached the default chain, although its docs say OpenDAL loads them from the env. azblob (#7589) and azdls (#8395) already sign withOsEnv.What changes are included in this PR?
OsEnvinstead of a syntheticStaticEnv. Configaccount_keyandsas_tokenstill take precedence.Verified against a real Azure Files share with one credential source per run: env shared key and env SAS token fail on main with
failed to load signing credential; here env shared key passes all 116 behavior tests, and env SAS token passes all but the 4 rename tests, which fail the same way with a config SAS on main. Config account key passes on both.Are there any user-facing changes?
azfile now loads credentials from the process environment, as its docs already describe. OAuth credentials still don't work, since azfile doesn't send the
x-ms-file-request-intentheader Azure Files requires for OAuth.Breaking changes
AI Usage Statement
AI-assisted implementation.