Repository navigation
Conversation
github-actions
Bot
added
releases-note/fix
YuangGao
force-pushed
the
fix/azfile-sas-rename
branch
from
October 29, 2026 02:10
fa00012 to
92304c7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A.
Rationale for this change
With a SAS token, azfile rename fails with
403 AuthorizationFailure:x-ms-file-rename-sourcecarries the bare source URL, and Azure Files authorizes the source separately from the request URI, which is the only place the SAS gets appended. The Azure Java SDK appends the SAS to the rename source for the same reason (ShareFileClient#renameWithResponse).What changes are included in this PR?
sas_tokento the rename source URL.Verified against a real Azure Files share: with a config SAS token, the 4 rename behavior tests fail on main with
403and pass here (116/116); config account key passes on both. A SAS token from the environment is not covered, since azfile only reads credentials from the environment after #8423.Are there any user-facing changes?
azfile rename now works with a SAS token.
Breaking changes
AI Usage Statement
AI-assisted implementation.