Skip to content

fix(services/azfile): load credentials from the process environment #8423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YuangGao wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(services/azfile): load credentials from the process environment #8423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 1 addition & 24 deletions core/services/azfile/src/backend.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,8 @@ use reqsign_azure_storage::DefaultCredentialProvider;
use reqsign_azure_storage::RequestSigner;
use reqsign_azure_storage::StaticCredentialProvider;
use reqsign_core::Context;
use reqsign_core::Env as _;
use reqsign_core::OsEnv;
use reqsign_core::Signer;
use reqsign_core::StaticEnv;
use reqsign_file_read_tokio::TokioFileRead;

use super::AZFILE_SCHEME;
Expand Down Expand Up @@ -192,28 +190,7 @@ impl Builder for AzfileBuilder {
),
}?;

let mut envs = std::collections::HashMap::new();
envs.insert("AZBLOB_ACCOUNT_NAME".to_string(), account_name.clone());
envs.insert(
"AZURE_STORAGE_ACCOUNT_NAME".to_string(),
account_name.clone(),
);

if let Some(v) = &self.config.account_key {
envs.insert("AZBLOB_ACCOUNT_KEY".to_string(), v.clone());
envs.insert("AZURE_STORAGE_ACCOUNT_KEY".to_string(), v.clone());
}
if let Some(v) = &self.config.sas_token {
envs.insert("AZURE_STORAGE_SAS_TOKEN".to_string(), v.clone());
}

let os_env = OsEnv;
let ctx = Context::new()
.with_file_read(TokioFileRead)
.with_env(StaticEnv {
home_dir: os_env.home_dir(),
envs,
});
let ctx = Context::new().with_file_read(TokioFileRead).with_env(OsEnv);

let mut credential = DefaultCredentialProvider::new();
if let Some(account_key) = self.config.account_key.as_deref() {
Expand Down
Loading