Repository navigation
fix: Escape also closes a menu opened by touch - #65
Merged
Merged
Conversation
A menu opened by touch has no focused view, so key events never reached its layout and Escape did not close it (found while testing #60). In touch mode the layout now takes focus; with a remote, focus stays on the menu items as before.
Collaborator
Author
|
/review |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can commit Qodo's fix in one click with committable suggestions (GitHub & GitLab) |
Collaborator
Author
|
Device test of the CI build on the AG-216 (Android 10):
The first OK after touching the screen only leaves touch mode, which is standard Android behaviour and the same as v2; the next OK opens the menu. Remote navigation inside the menu is unchanged. |
This was referenced Oct 12, 2026
compot-dev
added a commit
that referenced
this pull request
Oct 15, 2026
fix: Escape also closes a menu opened by touch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #60, found while device-testing #63.
Symptom: Escape closes the menu when it was opened with OK/Enter, but not when it was opened by tapping the screen.
Cause: a menu opened by touch is in touch mode with no focused view, so key events stop at the popup's decor view and never reach the layout's
dispatchKeyEvent, where #60 handles Escape. Back works because the decor view handles it itself.Fix: the menu layout is focusable in touch mode and takes focus when the menu opens in touch mode. When the menu is opened with a remote (not touch mode), focus stays on the menu items as before.
Device test with the CI build follows.