Repository navigation
feat: 8 camera slots, multi-view up to 3x3 (#13) - #64
Conversation
e3f6cba to
95a285e
Compare
95a285e to
fa5bb4a
Compare
|
Device test of the CI build
Two cameras could not be used, and both are camera limits rather than app issues: the XM model accepts only one RTSP client, and one SSC335 camera answers PLAY but sends no RTP (the JPEG snapshot works). The README screenshot is replaced by the 8-camera grid with the menu (3c5e39f). |
|
/review |
Code Review by Qodo
1.
|
- CAM_COUNT is 8 in Decoder and MenuManager; the menu row is Q, 1-8 - Multi-view shows a 2x2 grid while only slots 1-4 are used, and a 3x3 grid (the ninth cell stays black) once any of slots 5-8 has a URL. Cell index = slot index, so stored settings and the Quad audio choice stay compatible - The grid is built when multi-view starts or resumes, so it follows slot changes - Tests: grid size, 8 slots, slot clamping up to 7; READMEs updated
On a narrow screen or with a large font the last slot buttons could end up off-screen (Qodo). The row is now in a HorizontalScrollView, which also follows the focus when moving with a remote.
|
Re Later camera slots become unreachable: fixed in 22a50f2. The slot row (Q, 1–8) is now inside a /review |
3c5e39f to
22a50f2
Compare
feat: 8 camera slots, multi-view up to 3x3 (#13)
Closes #13. Stacked on #63 (SurfaceView cells); the base will be switched to v2 once #63 is merged.
What changes
QuadGridTest(grid size),savedSlotIsClampedupdated for 8 slots.Feasibility on the device (AG-216, Android 10, local debug build, 8 slots filled with the main streams of the 4 lab cameras, i.e. each camera twice):
Socket closed); this is a camera limit, not an app limit.JNISurfaceTexturethreads (fix: Quad cells render to SurfaceView (#61) #63). The two cells with the highest-resolution stream logged a queue overflow once each.The CI build will be device-tested before merging.