Skip to content

feat-homescreen - Add ModernCardsOnMyMediaRow setting support to Moonbase - #279

Merged
RadicalMuffinMan merged 1 commit into
Moonfin-Client:masterfrom
mattsigal:feature/modern-my-media-cards-toggle
Sep 9, 2026
Merged

feat-homescreen - Add ModernCardsOnMyMediaRow setting support to Moonbase#279
RadicalMuffinMan merged 1 commit into
Moonfin-Client:masterfrom
mattsigal:feature/modern-my-media-cards-toggle

Conversation

@mattsigal

@mattsigal mattsigal commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

Adds support for the new modernCardsOnMyMediaRow user preference across Moonbase DTO profiles, admin User Defaults UI, and settings synchronization for Jellyfin and Emby plugins.

Related Issues

Link related issues or tickets separated by commas.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • API / endpoint change
  • Settings schema change
  • Documentation update
  • Build/CI change
  • Other (describe):

Area

  • Settings sync / profiles
  • Admin defaults / config page
  • Ratings (MDBList / TMDB)
  • Notifications / Push (FCM / relay)
  • Seerr integration
  • Games / Emulators
  • Custom home rows
  • Web Client (Go to Moonfin-Core repo)
  • Other / shared

Changes Made

List the key changes included in this PR.

  • Added ModernCardsOnMyMediaRow (bool?) to MoonfinSettingsProfile.cs for both Jellyfin and Emby plugins.
  • Added "Modern cards on My Media row" dropdown selector and descriptive helper text to configPage.html under Default User Settings.
  • Bound modernCardsOnMyMediaRow in moonfin.js for profile load and save routines.

Client Impact

Does this need matching changes in a client repo (Core, Smart-TV, Roku)?

Compatibility

  • Change to the settings profile is additive only, no renamed or removed properties
  • New properties use the same type the client sends (a client bool maps to bool?, an int to int?)
  • Migration added for any renamed or removed settings
  • Older clients still work, unknown fields are ignored and no keys were removed

Testing

Describe how this change was tested.

  • Built the plugin and deployed to a Jellyfin server
  • Verified against a live client (which one:) Windows Desktop (core), Android TV (core), Smart-TV (webOS emulator)
  • Manual testing completed
  • Not tested (explain why):

Test Steps

  1. Built release DLL and deployed to server.
  2. Verified in Jellyfin Admin settings that default dropdown displays with choices "Not set", "Yes", and "No".
  3. Toggled setting and verified round-trip saving and persistence.

Screenshots (if applicable)

Include config page screenshots or request/response samples where relevant.

2026-09-08_20-30-15_brave

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced
  • Any new setting keys match the client-side keys exactly

- Add ModernCardsOnMyMediaRow to MoonfinSettingsProfile in Jellyfin and Emby
- Add Modern cards on My Media row default user setting and description in configPage.html
- Bind ModernCardsOnMyMediaRow in moonfin.js for settings save and load
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Build Successful

Both plugins compiled against .NET 8, and both test suites passed.

Property Value
Commit eec3530
Jellyfin ABI 10.10.0.0
Emby version 2.2.0.0
Workflow Build #384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants