Skip to content

feat-homescreen - Add toggle and mirrored sizing for Modern cards on My Media row - #263

Merged
RadicalMuffinMan merged 2 commits into
Moonfin-Client:masterfrom
mattsigal:feature/modern-my-media-cards-toggle
Sep 11, 2026
Merged

RadicalMuffinMan merged 2 commits into
Moonfin-Client:masterfrom
mattsigal:feature/modern-my-media-cards-toggle

Conversation

@mattsigal

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

Adds the ui.home.modernCardsOnMyMediaRow setting to Moonfin-Roku and preserves wide landscape card dimensions (WIDE_POSTER [464, 270]) on My Media row when expansion is disabled in Modern row layout.

Related Issues

Link related issues or tickets separated by commas.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

List the key changes included in this PR.

  • Added ui.home.modernCardsOnMyMediaRow setting entry to settings.json with title and description.
  • Added modernCardsOnMyMediaRow key to settingsSync.bs for server synchronisation.
  • Added isModernMyMediaCards() helper in misc.bs.
  • In HomeRows.bs, retained homeRowItemSizes.WIDE_POSTER [464, 270] on My Media row when modern cards expansion is disabled, matching the dimensions of the modern focus card overlay.
  • In Home.bs and HomeItem.bs, bypassed modern card shift and focus card overlay on My Media row when expansion is disabled.

Testing

Describe how this change was tested.

  • Tested on physical Roku device
  • Tested via sideload
  • Manual testing completed
  • Not tested (explain why): No Roku, No Cry. Pinging @jmawet.

Test Steps

  1. In Settings, verify "Modern cards on My Media row" setting exists under Home Screen settings.
  2. With Modern Home Rows enabled, disable "Modern cards on My Media row".
  3. Verify My Media row displays wide landscape posters sized to match the modern focus thumbnail overlay.

Screenshots (if applicable)

Include screenshots or recordings for UI changes.

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

- Add ui.home.modernCardsOnMyMediaRow setting to settings.json
- Add modernCardsOnMyMediaRow to settingsSync
- Keep WIDE_POSTER sizing and disable shift/focus card on My Media when modernCardsOnMyMediaRow is disabled
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Build Successful

The channel compiled and packaged. The sideload zip is on the run below.

Property Value
Build Passed
Commit e8943c6
Workflow run Build #18

@jmawet

jmawet commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

default (on):
image

toggle off:
image

image

@RadicalMuffinMan
RadicalMuffinMan merged commit 9e211ed into Moonfin-Client:master Sep 11, 2026
2 checks passed
@mattsigal
mattsigal deleted the feature/modern-my-media-cards-toggle branch September 14, 2026 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants