Skip to content

feat-homescreen - Add toggle and mirrored sizing for Modern cards on My Media row - #1462

Open
mattsigal wants to merge 1 commit into
Moonfin-Client:mainfrom
mattsigal:feature/modern-my-media-cards-toggle
Open

feat-homescreen - Add toggle and mirrored sizing for Modern cards on My Media row#1462
mattsigal wants to merge 1 commit into
Moonfin-Client:mainfrom
mattsigal:feature/modern-my-media-cards-toggle

Conversation

@mattsigal

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

Adds a user preference toggle modernCardsOnMyMediaRow (default true) under Home Screen settings when Modern row layout is active. When toggled off, My Media cards remain within the modern row layout engine and display static landscape artwork that mirrors the exact dimensions of the modern expanded focused thumbnail on neighboring rows across all card display sizes.

Related Issues

Link related issues or tickets separated by commas.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

List the key changes included in this PR.

  • Registered modernCardsOnMyMediaRow in user_preferences.dart and added to synced_fields.dart.
  • Added conditional toggle to home_sections_screen.dart and home_screen_category_screen.dart visible when Home Rows Style is Modern.
  • In home_screen.dart, kept My Media row within the modern layout engine when expansion is disabled; set card width to v2FocusedWidth, aspect ratio to 16:9, and requested ImageType.thumb landscape artwork to mirror neighboring focused thumbnails.
  • Generated localization across all supported locales in app_en.arb and app_localizations_*.dart.
  • Added comprehensive unit tests in modern_my_media_row_test.dart and updated synced_fields_test.dart.

Platform

  • Android
  • Android TV
  • iOS
  • tvOS
  • Web
  • macOS
  • Windows
  • Linux
  • All / Shared code

Testing

Describe how this change was tested.

  • Tested on emulator / simulator
  • Tested on physical device
  • Manual testing completed
  • Not tested (explain why):

Test Steps

  1. In Settings, verify "Modern cards on My Media row" setting exists under Home Screen settings.
  2. With Modern Home Rows enabled, disable "Modern cards on My Media row".
  3. Verify My Media row displays wide landscape posters sized to match the modern focus thumbnail overlay.

Screenshots (if applicable)

Include screenshots or recordings for UI changes.

Shield_Screenshot_2026-09-08_20-58-27 Shield_Screenshot_2026-09-08_20-58-47

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

- Register modernCardsOnMyMediaRow preference and add to synced_fields
- Add Modern cards on My Media row toggle to Home sections and Home category settings
- Keep My Media row within modern layout engine when expansion is disabled, mirroring expanded focused thumbnail dimensions across all poster sizes
- Add unit tests for modern My Media row behavior and synced fields
- Update localization with new keys
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

✅ Build Successful

All platform builds and tests passed. You can download the test artifacts below.

Tests ✅ 2057 passed, analyzer clean

Platform Status Artifact
Android ✅ Passed Moonfin_Android_v* + Moonfin_AndroidTV_v*
iOS ✅ Passed Moonfin_iOS_v*_unsigned.ipa
macOS ✅ Passed Moonfin_macOS_v*.dmg
tvOS ✅ Passed Moonfin_tvOS_v*_unsigned.ipa
Windows x64 ✅ Passed Moonfin_Windows_v*.exe
Windows ARM64 ✅ Passed Moonfin_WindowsARM64_v*.exe
Linux x64 ✅ Passed Moonfin_Linux_v* (deb/rpm/AppImage/snap/flatpak/tar.gz)
Linux ARM64 ✅ Passed Moonfin_LinuxARM64_v* (deb/rpm/AppImage/snap/flatpak/tar.gz)
Property Value
Commit 57325cb
Workflow run Build #1347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

All Feature Request New feature or request UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] Vertical display of libraries - display text cut off

1 participant