feat-homescreen - Add toggle and mirrored sizing for Modern cards on My Media row - #1462
Open
mattsigal wants to merge 1 commit into
Open
feat-homescreen - Add toggle and mirrored sizing for Modern cards on My Media row#1462mattsigal wants to merge 1 commit into
mattsigal wants to merge 1 commit into
Conversation
- Register modernCardsOnMyMediaRow preference and add to synced_fields - Add Modern cards on My Media row toggle to Home sections and Home category settings - Keep My Media row within modern layout engine when expansion is disabled, mirroring expanded focused thumbnail dimensions across all poster sizes - Add unit tests for modern My Media row behavior and synced fields - Update localization with new keys
Merged
34 tasks
✅ Build SuccessfulAll platform builds and tests passed. You can download the test artifacts below. Tests ✅ 2057 passed, analyzer clean
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Adds a user preference toggle
modernCardsOnMyMediaRow(defaulttrue) under Home Screen settings when Modern row layout is active. When toggled off, My Media cards remain within the modern row layout engine and display static landscape artwork that mirrors the exact dimensions of the modern expanded focused thumbnail on neighboring rows across all card display sizes.Related Issues
Link related issues or tickets separated by commas.
Type of Change
Changes Made
List the key changes included in this PR.
modernCardsOnMyMediaRowin user_preferences.dart and added to synced_fields.dart.v2FocusedWidth, aspect ratio to 16:9, and requestedImageType.thumblandscape artwork to mirror neighboring focused thumbnails.Platform
Testing
Describe how this change was tested.
Test Steps
Screenshots (if applicable)
Include screenshots or recordings for UI changes.
Checklist