Repository navigation
feat(mixins): add theme-markers mixin - #668
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change separating theme markers from component CSS variables.
No open issues 🎉
What changed in this PR
Separates theme-marker declarations from component CSS variables, allowing direct callers to avoid redundant markers while preserving scoped tokens() and Tailwind utility output.
Changes:
- Adds the public
theme-markers($theme, $variant)mixin. - Removes marker emission from
css-vars-from-theme()and adds explicit calls where existing output must be preserved. - Updates tests for marker-free component variables and explicit marker emission.
| File | Description |
|---|---|
packages/theming/tests/_themes.spec.scss |
Updates expected output and adds theme-marker tests. |
packages/theming/sass/themes/_mixins.scss |
Extracts marker emission into a public mixin and integrates it with scoped tokens. |
packages/theming/sass/tailwind/_mixins.scss |
Explicitly emits markers to preserve utility output. |
Review effort: Balanced
simeonoff
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #616
theme-markers($theme, $variant)mixin. It declares--ig-themeand--ig-theme-variantonly where it's included.css-vars-from-theme()no longer emits the markers. It now emits only the component's variables, so code that calls it directly, such as the Web Components sheets and the Angular scrollbar, no longer gets them.tokens()includestheme-markers()in scoped mode, so its output is unchanged: scoped mode still declares the markers and global mode still doesn't. The Tailwind utilities include it too, so their output is unchanged as well.