Skip to content

refactor(themes): declare the theme markers with theme-markers() - #17950

Merged
simeonoff merged 3 commits into
masterfrom
apetrov/theme-markers-mixin
Nov 10, 2026
Merged

simeonoff merged 3 commits into
masterfrom
apetrov/theme-markers-mixin

Conversation

@adrianptrv

Copy link
Copy Markdown
Contributor

Follow-up to this theming PR: IgniteUI/igniteui-theming#668

Description

What changed

  • The theme generator (core/src/core/styles/themes/generators/_base.scss) declares --ig-theme and --ig-theme-variant with igniteui-theming's new theme-markers() mixin instead of writing them by hand. The output is the same.

Output changes from the igniteui-theming update

  • css-vars-from-theme() no longer emits the markers, so the scrollbar() mixin, which calls it directly, no longer declares them on its parent and on .ig-scrollbar.
  • component-tokens() goes through tokens($mode: 'scoped'), which still declares the markers, so component output is unchanged.

Type of Change (check all that apply):

  • Refactoring (no functional changes)

How Has This Been Tested?

  • Manual testing

Checklist:

  • All relevant labels have been applied to this PR

Waiting on

  • igniteui-theming version that includes the theme-markers() mixin.

@adrianptrv
adrianptrv requested a review from simeonoff November 9, 2026 11:28
@adrianptrv adrianptrv added ✨ themes enhancement New feature or request labels Nov 9, 2026
@adrianptrv
adrianptrv marked this pull request as ready for review November 10, 2026 09:38
Copilot AI balanced review requested due to automatic review settings November 10, 2026 09:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the theme-marker mixin and dependency updates.

No open issues 🎉

What changed in this PR

Updates Angular’s theme generator to use igniteui-theming’s theme-markers() mixin, following the upstream theming refactor while preserving the generator’s marker output.

Changes:

  • Replaces handwritten --ig-theme and --ig-theme-variant declarations with theme-markers().
  • Updates library and workspace dependencies to igniteui-theming ^30.2.0 and locks version 30.2.0.
File Description
projects/​igniteui-angular/​package.json Updates the library’s theming dependency range.
projects/​igniteui-angular/​core/​src/​core/​styles/​themes/​generators/​_base.scss Uses the shared mixin to emit theme markers.
package.json Updates the workspace’s theming dependency range.
package-lock.json Locks the updated theming package and integrity hash.

Review effort: Balanced

@simeonoff
simeonoff enabled auto-merge (squash) November 10, 2026 09:51
@simeonoff
simeonoff merged commit c91e71f into master Nov 10, 2026
8 checks passed
@simeonoff
simeonoff deleted the apetrov/theme-markers-mixin branch November 10, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants