Repository navigation
refactor(themes): declare the theme markers with theme-markers() - #17950
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the theme-marker mixin and dependency updates.
No open issues 🎉
What changed in this PR
Updates Angular’s theme generator to use igniteui-theming’s theme-markers() mixin, following the upstream theming refactor while preserving the generator’s marker output.
Changes:
- Replaces handwritten
--ig-themeand--ig-theme-variantdeclarations withtheme-markers(). - Updates library and workspace dependencies to
igniteui-theming^30.2.0and locks version30.2.0.
| File | Description |
|---|---|
projects/igniteui-angular/package.json |
Updates the library’s theming dependency range. |
projects/igniteui-angular/core/src/core/styles/themes/generators/_base.scss |
Uses the shared mixin to emit theme markers. |
package.json |
Updates the workspace’s theming dependency range. |
package-lock.json |
Locks the updated theming package and integrity hash. |
Review effort: Balanced
simeonoff
approved these changes
Nov 10, 2026
simeonoff
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to this theming PR: IgniteUI/igniteui-theming#668
Description
What changed
core/src/core/styles/themes/generators/_base.scss) declares--ig-themeand--ig-theme-variantwith igniteui-theming's newtheme-markers()mixin instead of writing them by hand. The output is the same.Output changes from the igniteui-theming update
css-vars-from-theme()no longer emits the markers, so thescrollbar()mixin, which calls it directly, no longer declares them on its parent and on.ig-scrollbar.component-tokens()goes throughtokens($mode: 'scoped'), which still declares the markers, so component output is unchanged.Type of Change (check all that apply):
How Has This Been Tested?
Checklist:
Waiting on
theme-markers()mixin.