Skip to content

refactor(styles): use the new theme-markers() mixin and remove the local wrapper - #2588

Merged
simeonoff merged 3 commits into
masterfrom
apetrov/theme-markers-mixin
Nov 10, 2026
Merged

simeonoff merged 3 commits into
masterfrom
apetrov/theme-markers-mixin

Conversation

@adrianptrv

Copy link
Copy Markdown
Contributor

Follow-up to this theming PR: IgniteUI/igniteui-theming#668

Description

Removed the local css-vars-from-theme() wrapper from src/styles/utilities/_overwrites.scss and replaced it with the new theme-markers() mixin.

Type of Change

  • Refactoring (code improvements without functional changes)

Checklist

  • My code follows the project's coding standards
  • I have tested my changes locally

Waiting on

  • igniteui-theming version that includes the theme-markers() mixin.

@adrianptrv
adrianptrv requested a review from simeonoff November 9, 2026 10:57
@adrianptrv adrianptrv added enhancement New feature or request themes styling labels Nov 9, 2026
@adrianptrv
adrianptrv marked this pull request as ready for review November 10, 2026 10:17
Copilot AI balanced review requested due to automatic review settings November 10, 2026 10:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the Sass theming changes.

No open issues 🎉

What changed in this PR

This PR simplifies the library’s Sass theming utilities by adopting the upstream theme-markers() mixin and removing the local wrapper.

Changes:

  • Replace manually emitted root theme markers with theme-markers().
  • Remove the local css-vars-from-theme() wrapper and expose the upstream mixin directly.
  • Update igniteui-theming to ^30.2.0, with the lockfile resolving version 30.2.0.
File Description
src/​styles/​utilities/​_overwrites.scss Remove the local wrapper and its unused imports.
src/​styles/​utilities/​_index.scss Forward all upstream theme mixins without hiding css-vars-from-theme.
src/​styles/​themes/​base/​_theme.scss Use theme-markers() for root theme metadata.
package.json Raise the theming dependency to ^30.2.0.
package-lock.json Lock the updated theming dependency to 30.2.0.

Review effort: Balanced

@simeonoff
simeonoff merged commit 525f126 into master Nov 10, 2026
11 checks passed
@simeonoff
simeonoff deleted the apetrov/theme-markers-mixin branch November 10, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request styling themes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants