Repository navigation
refactor(styles): use the new theme-markers() mixin and remove the local wrapper - #2588
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the Sass theming changes.
No open issues 🎉
What changed in this PR
This PR simplifies the library’s Sass theming utilities by adopting the upstream theme-markers() mixin and removing the local wrapper.
Changes:
- Replace manually emitted root theme markers with
theme-markers(). - Remove the local
css-vars-from-theme()wrapper and expose the upstream mixin directly. - Update
igniteui-themingto^30.2.0, with the lockfile resolving version30.2.0.
| File | Description |
|---|---|
src/styles/utilities/_overwrites.scss |
Remove the local wrapper and its unused imports. |
src/styles/utilities/_index.scss |
Forward all upstream theme mixins without hiding css-vars-from-theme. |
src/styles/themes/base/_theme.scss |
Use theme-markers() for root theme metadata. |
package.json |
Raise the theming dependency to ^30.2.0. |
package-lock.json |
Lock the updated theming dependency to 30.2.0. |
Review effort: Balanced
simeonoff
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to this theming PR: IgniteUI/igniteui-theming#668
Description
Removed the local
css-vars-from-theme()wrapper fromsrc/styles/utilities/_overwrites.scssand replaced it with the newtheme-markers()mixin.Type of Change
Checklist
Waiting on
theme-markers()mixin.