Repository navigation
build(desktop): Windows packaging script (NSIS and MSI, experimental, unsigned) - #79
Merged
Merged
Conversation
…ndows config without updater, docs (SmartScreen, WebView2)
… by the first CI run)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
6 tasks done
…r untouched, not require its absence (Codex review)
EVMCOD
added a commit
that referenced
this pull request
Oct 29, 2026
ci(desktop): build Windows NSIS and MSI artifacts on windows-latest (stacked on #79)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
PR 1 of the Windows packaging, done the way Linux was (#69): a script that builds the installer. Experimental and unsigned. It does not publish anything and does not touch the macOS release.
scripts/build-windows.ps1(new, PowerShell, ASCII only, consistent withbuild-linux.sh): freezes the PyInstaller sidecar, copies it todesktop/src-tauri/binaries/conductloop-server-x86_64-pc-windows-msvc.exe(Tauri's triple naming), then runstauri build --bundles nsis(default) or-Bundles nsis,msi. Options:-SidecarOnly,-SkipSidecar,-Bundles,-Help. Builds in its own venv (build\windows-venv), dropssentence-transformersfrom the sidecar like the other builds, stripsTAURI_SIGNING_*from the environment, remaps the user profile out of the Rust binary, refuses to run off 64-bit Windows, prints sizes and sha256 at the end.desktop/src-tauri/tauri.windows.conf.json(new): applies on Windows only (Tauri merges it overtauri.conf.json). NSIS target, per-user install (currentUser, no admin prompt), WebView2downloadBootstrapper, no updater artifacts. macOS and Linux configs are untouched.desktop/src-tauri/src/lib.rsnow runs the startup update check on macOS only (cfg!(target_os = "macos")). The plugin and its config stay registered on every platform; the "Check for Updates" menu item was already macOS-only.desktop/conductloop_server.spec: onwin32only, the frozen server starts with-X utf8(frozen executables ignorePYTHONUTF8; the Windows console and file default is cp1252). Other platforms: no change.docs/PORTABILITY.mdhas a new "Windows status" section: experimental, unsigned, WebView2 requirement, SmartScreen ("More info" then "Run anyway"), possible antivirus false positives, known limits.lib.rsline (test_linux_packaging.py,test_linux_update_manifest.py) now assert the macOS-only line.Not touched:
release-desktop.sh, the macOS CI,build-linux.sh, Stripe, the license worker, Apple secrets. No secrets, no signing, no.sig.How it was tested
scripts/verify.sh --offlineon this branch (final commit 3ea5063): passed, ruff, mypy ratchet,pytest -m "not live"with coverage, evals, package build, gitleaks (excluded as they hang on the box:tests/test_browser_visibility_js.py,tests/test_desktop_nav_js.py;tests/test_license_worker.pynot run).tests/test_windows_packaging.py(new): override touches onlybundle; macOS/Linux configs unchanged; NSIS,currentUser, WebView2; no updater artifacts or signing keys; plugin config kept; sidecar andicon.icoexist; macOS-only update check; the updater endpoint is still the macOS one; spec option on win32 only; script structure (triple, sidecar name, bundle validation, no signing or publishing words, ASCII only);release-desktop.shandbuild-linux.shdo not reference it; docs mention SmartScreen, "More info", "Run anyway", WebView2. Withpwshon the box also: the script parses,-Helpworks, bad options are refused (-Bundles dmg,nsis;calc,-SidecarOnly -SkipSidecar), and it refuses to run off Windows.windows-latestrunner (the box has no Windows and cannot compile Rust), through the workflow of the next PR in the stack (ci/windows-bundles, on a scratch branch): the script built the NSIS installer and the MSI from this branch's code (run 40946201670, success), the frozen server answered/api/health, and the silently installed app started its server on :7777. The first run (40945979171) failed in 27 s on a bug in this script (-Bundles nsis,msibound to a[string]); fixed in 3ea5063, the cause is in the commit message.Untested ("sin probar", nothing here was run on a real Windows machine)
-X utf8beyond the server answering health.lib.rschange was compiled only by CI (the box cannot build Rust).Checklist
scripts/verify.sh.CHANGELOG.mdentry under Unreleased.docs/PORTABILITY.md).