Repository navigation
ci(desktop): build Windows NSIS and MSI artifacts on windows-latest (stacked on #79) - #80
Merged
Merged
Conversation
…atest (artifacts for 3 days); the guard lists the bundle workflows
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…to ci/windows-bundles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is stacked on #79 (
build/windows-package-script) and its base is that branch, notmain. It runsscripts/build-windows.ps1, which only exists in #79. Merge #79 first; GitHub then retargets this PR tomain(or retarget it by hand). The diff here is only the workflow, its test, the guard, a CHANGELOG line and a docs bullet. Same shape as #70 for Linux.What
A new workflow,
.github/workflows/windows-bundles.yml, with one job (windows-bundles) that builds the Windows NSIS installer (.exe) and MSI withscripts/build-windows.ps1 -Bundles nsis,msiand keeps them as artifacts.windows-latest(GitHub-hosted, literal label; novars.RUNS_ON, no self-hosted).timeout-minutes: 60,permissions: contents: read.workflow_dispatchonly. Not on push, not on pull_request, not scheduled, so it is not a required check and never runs by itself. (GitHub only lets you dispatch a workflow that exists on the default branch: after this merges, run it withgh workflow run windows-bundles.yml --ref <branch>.)rust-cacheondesktop/src-tauri; the build script; sizes and sha256 into the job summary; two smoke tests (below); twoupload-artifactsteps.conductloop-server.exestarts and answers/api/health(blocking); (2) the NSIS installer is installed silently (/S, per user) and the installed app is started and must start its server on :7777 (continue-on-error: true, informational).conductloop-windows-nsisandconductloop-windows-msi,retention-days: 3,if-no-files-found: error.upload-artifactv7.0.2, as inlinux-bundles.yml).tests/test_workflows_guard.py):windows-latestwas already allowed, so no pinned-image exception is needed. The "closed list" gets a newBUNDLE_WORKFLOWSset: only those workflows may upload artifacts and only withretention-days: 3; andwindows-latestis checked to be the runner of this job.docs/PORTABILITY.md: a bullet about the CI bundle job. CHANGELOG line under Unreleased.How it was tested
scripts/verify.sh --offlineon this branch (4d4dca8): passed (tests/test_browser_visibility_js.py,tests/test_desktop_nav_js.pyexcluded because they hang on the box;tests/test_license_worker.pynot run).tests/test_windows_bundles_workflow.py(new) and the extendedtests/test_workflows_guard.py.windows-latestrunner, from a scratch branchwip/windows-bundles-validation(the same workflow plus apushtrigger; a not-yet-merged workflow cannot be dispatched, GitHub answers 404). That branch is only for validation and must never be merged. Its content equals this branch except those 4 trigger lines.windows-latest(D:\a\conductloop, PowerShell 7, Python 3.14.9), 10 min 44 s. NSIS and MSI were built; the frozen server answered/api/health; the silently installed app (conductloop-desktop.exe,conductloop-server.exe) started its server on :7777.conductloop-windows-nsis/ConductLoop_1.2.3_x64-setup.exe83 457 010 bytes, sha2562bf07bd17227ffd4fce53bf506241f3b266d3ff5cc16b8e07e02ce3b3dccdd8a;conductloop-windows-msi/ConductLoop_1.2.3_x64_en-US.msi84 439 040 bytes, sha2564f3d09dde533c804edc3319ec47f119216887c03b2465822107b4e612e50b733. They match the sha256 in the job summary.-Bundles nsis,msi), fixed in build(desktop): Windows packaging script (NSIS and MSI, experimental, unsigned) #79. The setup steps passed, so it was not a spending-limit failure.Untested ("sin probar")
workflow_dispatchtrigger itself was not exercised from the default branch (only possible after merge); the job was exercised through the scratch branch'spushtrigger.Checklist
scripts/verify.sh.CHANGELOG.mdentry under Unreleased.windows-latest), action SHAs pinned with a version comment, permissionscontents: read.