fix(pack-update): 修复 ootb TS2353 + defaultBindingEnabled 契约(含 #62) - #63
Merged
Tanya7z merged 1 commit intoJul 24, 2026
Merged
Conversation
ootb@b52e487 在 cli 声明发出阶段失败:DEFAULTS 写了 defaultBindingEnabled 但 PackUpdateConfig 未声明(TS2353)。同时补齐绑定写入接线,并合入 审查 #62 的 match 顶层化与按 binding.provider 分派。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Tanya7z
marked this pull request as ready for review
July 24, 2026 12:12
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
main@b52e487(移除 SEA)合入时顺带加入defaultBindingEnabled,但未写入PackUpdateConfig类型、也未接线绑定创建。ootb run30091402964在 Build all workspaces 失败:同时开放的 #62(顶层 match / provider 分派)与该变更在
pack-update.json/config.ts冲突;本 PR 一并 rebase 合入,避免双轨。审查(原则标注)
DEFAULTS.defaultBindingEnabled不在类型上 → CI 红makeBindingFromHit硬编码enabled: true,与配置默认false及 i18n{enabled}不一致match仍挂在providers.curseforge(#62)createPackSourceProvider忽略binding.provider(#62)getProvider;archivePath→stagingDir;清掉 SEA 拆除后残留的jsonc-parser/@types/cli-progress改动
PackUpdateConfig.defaultBindingEnabled+ 新建绑定走该默认;重绑保留原enabledbindOk传入{enabled}(on/off)match顶层化 + 兼容旧嵌套;createPackSourceProvider(cfg, id)exhaustive switch验证
npm run typecheck -w @sfmc-bds/clinpm test -w @sfmc-bds/cli(12 pass)npm test -w @sfmc-bds/bds-tools(21 pass)SFMC_ROOT:旧嵌套 match 提升 +defaultBindingEnabled默认 false说明
合入后可关闭 #62(内容已包含)。SEA 拆除本身审查通过,无额外代码残留(
IS_SEA/build-sea/release.yml已清)。