fix(pack-update): 修复 merge 后 bindOk 重复 enabled(ootb TS1117) - #65
Merged
Tanya7z merged 2 commits intoJul 24, 2026
Merged
Conversation
ootb@baff02a 在 Build 阶段因 probeSourceAfterInstall 的 bindOk 对象字面量合并留下两个 enabled 键而失败。保留实际写入的 binding.enabled 文案(LSP),并让 sources list 复用同一 helper(DRY); 顺带收敛 lastFileId/lastApplied 的重复 setBinding 分支。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Tanya7z
marked this pull request as ready for review
July 24, 2026 12:37
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
ootb@
baff02a(Merge「修复更新相关内容」+ #63)失败:Run: https://github.com/DogeLakeDev/ScriptsForMinecraftServer/actions/runs/30093374459
审查(原则标注)
probeSourceAfterInstall的bindOk合并后并列两个enabled(#63 的bindingEnabledLabel+ 526a65c 的 cfg 派生),tsc7 直接红bindingEnabledLabel硬编码on/off,formatSourcesList另写packs.list.*prepareCheck在remoteNewer两分支重复lastFileId+setBindingdocs/guide/pack-update.md字段表重复defaultBindingEnabled/ 裸nameMinScore与match.*改动
bindOk只保留实际写入的binding.enabled文案(LSP)bindingEnabledLabel走packs.list.on/off;formatSourcesList复用lastFileId/lastAppliedFileId写入为单次setBindingmatch.*保留 526a65c 意图:
lastAppliedFileId跳过重复下载、applyUpdate返回{ok,message}、bindingLabelForUuid显示src=tag:off。验证
npm run build --workspaces --if-presentnpm run typecheck -w @sfmc-bds/clinpm test -w @sfmc-bds/cli(12 pass)未改(交给已开 #64)
resolveConfiguredPackProvider/ CF→httpDownload/bindByteProgressToBar/ i18n{provider}:— 见 fix(pack-update): DRY/OCP 收敛 provider 解析与流式下载 #64;合本 PR 后 fix(pack-update): DRY/OCP 收敛 provider 解析与流式下载 #64 需 rebase