fix(pack-update): DRY/OCP 收敛 provider 解析与流式下载 - #64
Merged
Tanya7z merged 1 commit intoJul 24, 2026
Conversation
审查 main@c9a58ea（#63 合入后）：入口四处写死 curseforge/needKey、 i18n 写死 cf:、CF 下载整包进内存、进度环路与 BDS 更新重复。 - resolveConfiguredPackProvider / providerShortLabel 注册表化 - bindOk/probeAutoBind 使用 {provider} 占位（LSP） - CF download 改走 bds-tools/httpDownload + 导出 ./http - SDK bindByteProgressToBar 供 BDS/CF 共用；无 Content-Length 也回调 - CLAUDE.md 去掉已删除的 panel/；补充 config 契约测试 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Tanya7z
marked this pull request as ready for review
July 24, 2026 12:32
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
Push
main@c9a58ea（合并 #63）后 ootb 已绿。对 #63 / SEA 拆除后的 pack-update 残余做 SOLID 审查并直接出补丁。审查（原则标注）
probe/search/bind/check四处写死createPackSourceProvider(cfg, "curseforge")+needKeybindOk/probeAutoBind写死cf:，与binding.provider分派契约不一致download自建 fetch+整包进内存，与 BDShttpDownload重复且大包有 OOM 风险lastTime/lastLoaded进度环路CLAUDE.md仍文档化已删除的panel/改动
resolveConfiguredPackProvider/providerShortLabel进入 providers 注册表；编排入口统一解析{provider}:{slug}@sfmc-bds/bds-tools/http（新增 exports./http）；无 Content-Length 时仍回调进度bindByteProgressToBar；BDScheck-update与 CF 共用（失败重试每次新建 binder）CLAUDE.md对齐 sfmc CLI；新增pack-update-config.test.mjs验证
npm run typecheck -w @sfmc-bds/cli/bds-toolsnpm test -w @sfmc-bds/cli（15 pass）npm test -w @sfmc-bds/bds-tools（21 pass）未改
ServiceIdpack-manager 注册（主路径已不 spawn）