Skip to content

fix(ci@3d15949): #33 合并残留 TS6133 + configs/all banned_items / canDisable LSP - #34

Closed
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/bc-fdde6d81-a3f1-453b-8716-177a05d6943b-24b0
Closed

fix(ci@3d15949): #33 合并残留 TS6133 + configs/all banned_items / canDisable LSP#34
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/bc-fdde6d81-a3f1-453b-8716-177a05d6943b-24b0

Conversation

@cursor

@cursor cursor Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

背景

ootb 在 merge #33 后失败(run 29940895451main@3d15949)。

sfmc/src/repl.ts(25,7): error TS6133: 'MODULE_HELP_LABEL' is declared but its value is never read.

#32#33 并行修同一 ootb 问题后合并冲突残留:HELP 已改用 paintModuleCmdAlias,但 MODULE_HELP_LABEL 未删,tsc noUnusedLocals 打断 workspace build。

审查结论(DRY / OCP / DIP / LSP / Demeter)

级别 原则 处理
BLOCKER DRY #33 合入后 MODULE_HELP_LABEL 死代码 → TS6133 删除;HELP 只走 paintModuleCmdAlias
MINOR DRY 未使用的 MODULE_CMD_ALIAS_LABEL 导出 删除
MAJOR LSP configs/all.banned_items{item_id}[],ConfigManager 期望 string[] → 永远空 getAllConfigs 复用 getBannedItems(): string[]
MAJOR LSP canDisable 缺省:list=true,disable 当 falsy 拒 resolveModuleByKey 规范化 canDisable !== false
MINOR DRY getAllConfigs 重复过滤/映射 改为调用各资源 helper

未改(已知设计债):db.tx 两阶段读回、enable 热更新 token、service.get 丢 code、cleanupModule 清全部 context。

验证

npm run build --workspaces --if-present   # PASS(含 @sfmc-bds/cli tsc)
SFMC_ROOT=$PWD node tools/check-ootb.mjs  # 11/11 PASS
# 隔离 SFMC_ROOT:banned_items string[];缺省 canDisable 可 disable
Open in Web View Automation 

#32+#33 并行合入后 repl.ts 仍保留 MODULE_HELP_LABEL,但 HELP
已改用 paintModuleCmdAlias,tsc noUnusedLocals → TS6133 打断 ootb。
同步:删死导出 MODULE_CMD_ALIAS_LABEL;configs/all banned_items 回
string[] 并对齐 helper;resolveModuleByKey 规范化 canDisable(LSP)。

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
cursor Bot pushed a commit that referenced this pull request Jul 22, 2026
#33 合入后 HELP 只走 paintModuleCmdAlias;死导出会再触发 noUnusedLocals。
与并行 #34 对齐,避免双 PR 漏删。

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
与并行 #35 对齐:service 客户端勿一律打成 internal(LSP);
ootb 回归守卫 configs/all.banned_items 必须为 string[]。

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
cursor Bot pushed a commit that referenced this pull request Jul 22, 2026
…e LSP

与并行 #34/#35 对齐并超集:
- moduleCanDisable 供 list/disable 同源
- getAllConfigs 委托单资源 helpers;banned_items 权威 string[]
- ConfigManager 兼容历史 {item_id};ootb 锁形状
- service.get 保留服务端 code(勿一律 internal)

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

并行 PR 说明

本 PR 与 #35/#36 同修 main@3d15949#33 合并)的 TS6133 + banned_items/canDisable LSP。

建议关闭本 PR,改合 #36:已吸收本 PR 的 CI/LSP 修复,并额外包含 enable 热同步 token/enabledSet(MAJOR DIP,本 PR / #35 明确未做)。

View PR

Open in Web View Automation 

Sent by Cursor Automation: SFMC-Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants