fix(ci@3d15949): #33 合并残留 TS6133 + configs/all banned_items / canDisable LSP - #34
Closed
cursor[bot] wants to merge 2 commits into
Closed
fix(ci@3d15949): #33 合并残留 TS6133 + configs/all banned_items / canDisable LSP#34cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
与并行 #35 对齐:service 客户端勿一律打成 internal(LSP); ootb 回归守卫 configs/all.banned_items 必须为 string[]。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
This was referenced Jul 22, 2026
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


背景
ootb在 merge #33 后失败(run 29940895451,main@3d15949)。#32 与 #33 并行修同一 ootb 问题后合并冲突残留:HELP 已改用
paintModuleCmdAlias,但MODULE_HELP_LABEL未删,tsc noUnusedLocals打断 workspace build。审查结论(DRY / OCP / DIP / LSP / Demeter)
MODULE_HELP_LABEL死代码 → TS6133paintModuleCmdAliasMODULE_CMD_ALIAS_LABEL导出configs/all.banned_items为{item_id}[],ConfigManager 期望string[]→ 永远空getAllConfigs复用getBannedItems(): string[]canDisable缺省:list=true,disable 当 falsy 拒resolveModuleByKey规范化canDisable !== false未改(已知设计债):db.tx 两阶段读回、enable 热更新 token、service.get 丢 code、cleanupModule 清全部 context。
验证