fix(push@7c6c9c1): npm-publish 空 jobs + HttpDB DataAdapter / db-routes 信封 - #25
Closed
cursor[bot] wants to merge 2 commits into
Closed
fix(push@7c6c9c1): npm-publish 空 jobs + HttpDB DataAdapter / db-routes 信封#25cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
workflow_dispatch.inputs.tag 改为非 required,publish job 增加 ref_type==tag 门控,避免改 workflow 的 branch push 被 GHA 误评估后 出现空 jobs + "workflow file issue"(如 run 29922880511)。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
- installHostBootstrap 默认注入 createHttpDataAdapter,可经
dataAdapter / dbServerUrl 替换;HttpDB.configure 覆盖基址
- db-routes 错误路径统一 jsonV2Fail({ok:false}),支持 step extra
Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
审查 main@7c6c9c1(npm-publish 改为
tags: **+ job 级@sfmc-bds/门控)。ootb 绿。仍未合入的空 jobs 根因:
workflow_dispatch.inputs.tag: required: true— 改 workflow 的 branch push 会被 GHA 误评估,出现空 jobs / workflow file issue(如 29922880511)。本 PR 取代冲突中的 #24(同一修法 rebase 到最新 main)。
审查结论(DRY / OCP / DIP / LSP / Demeter)
required:true→ 空 jobs 失败required:false+ref_type==tag门控installHostBootstrap仍 stub DataAdapter,硬编码 HttpDB 布局createHttpDataAdapter+ 可注入db-routes错误路径混用{success:false}jsonV2Fail({ok:false})tags:**会误触 SEAv*(job skipped 绿)db.txrecorder 不回放 serverresultssuccess方言修复
CI
inputs.tag→required: false(空 tag 仍由resolve-npm-publish-tag.mjs拒绝)publishjob:workflow_dispatch || (ref_type==tag && startsWith(@sfmc-bds/))SOLID
createHttpDataAdapter;HttpDB.configure/dbServerUrl/dataAdapterjsonV2Fail支持extra(如step);db-routes 错误路径对齐验证
db-servernode --test:7/7SFMC_ROOT=$PWD node tools/check-ootb.mjs:10/10