Skip to content

fix(push@7c6c9c1): npm-publish 空 jobs + HttpDB DataAdapter / db-routes 信封 - #25

Closed
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/bc-04f0de72-38d2-4ae9-a1cc-77d78d7ef88c-e915
Closed

fix(push@7c6c9c1): npm-publish 空 jobs + HttpDB DataAdapter / db-routes 信封#25
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/bc-04f0de72-38d2-4ae9-a1cc-77d78d7ef88c-e915

Conversation

@cursor

@cursor cursor Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

背景

审查 main@7c6c9c1(npm-publish 改为 tags: ** + job 级 @sfmc-bds/ 门控)。ootb 绿。

仍未合入的空 jobs 根因:workflow_dispatch.inputs.tag: required: true — 改 workflow 的 branch push 会被 GHA 误评估,出现空 jobs / workflow file issue(如 29922880511)。

本 PR 取代冲突中的 #24(同一修法 rebase 到最新 main)。

审查结论(DRY / OCP / DIP / LSP / Demeter)

级别 原则 处理
BLOCKER DRY/CI required:true → 空 jobs 失败 本 PR:required:false + ref_type==tag 门控
MAJOR DIP installHostBootstrap 仍 stub DataAdapter,硬编码 HttpDB 布局 本 PR:createHttpDataAdapter + 可注入
MAJOR LSP/DRY db-routes 错误路径混用 {success:false} 本 PR:统一 jsonV2Fail({ok:false})
MINOR tags:** 会误触 SEA v*(job skipped 绿) 接受:与 7c6c9c1 意图一致;job if 已挡
未改 LSP db.tx recorder 不回放 server results 需两阶段协议
未改 MINOR 平台 legacy 路由仍 success 方言 客户端双认

修复

CI

  • inputs.tagrequired: false(空 tag 仍由 resolve-npm-publish-tag.mjs 拒绝)
  • publish job:workflow_dispatch || (ref_type==tag && startsWith(@sfmc-bds/))

SOLID

  • createHttpDataAdapterHttpDB.configure / dbServerUrl / dataAdapter
  • jsonV2Fail 支持 extra(如 step);db-routes 错误路径对齐

验证

  • db-server node --test:7/7
  • SFMC_ROOT=$PWD node tools/check-ootb.mjs:10/10
Open in Web View Automation 

cursoragent and others added 2 commits July 22, 2026 13:39
workflow_dispatch.inputs.tag 改为非 required,publish job 增加
ref_type==tag 门控,避免改 workflow 的 branch push 被 GHA 误评估后
出现空 jobs + "workflow file issue"(如 run 29922880511)。

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
- installHostBootstrap 默认注入 createHttpDataAdapter,可经
  dataAdapter / dbServerUrl 替换;HttpDB.configure 覆盖基址
- db-routes 错误路径统一 jsonV2Fail({ok:false}),支持 step extra

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants