fix(wf@ba65eb9): @sfmc-bds/tools workspaces 发包失败 + DataAdapter / db-routes 信封 - #28
Merged
Tanya7z merged 1 commit intoJul 22, 2026
Merged
Conversation
npm 安装后 ROOT=SFMC_ROOT,拼 ROOT/tools 会找不到脚本; 改为相对本包目录解析 fetch-module.mjs。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/bc-26fb0815-c4b6-4f6e-ae7b-f31433c4326f-fea2
branch
from
July 22, 2026 14:10
ec67511 to
67ac699
Compare
Tanya7z
marked this pull request as ready for review
July 22, 2026 14:10
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
npm-publish run 29926818842 在 tag
@sfmc-bds/tools@v0.1.0(main@ba65eb9)失败:ba65eb9 已把包写入
NPM_PUBLISH_PACKAGES,但 rootworkspaces未含tools,npm run build -w/npm publish -w均不可用。ootb 同 commit 已绿。本 PR 取代 #24 / #25 / #26 / #27(同批 CI 空 jobs + tools 发包 + SOLID 信封)。
审查结论(DRY / OCP / DIP / LSP / Demeter)
tools未进 root workspaces / pack:verifymain: check-ootb.js不存在;无可用 build 面.mjs+ bin/files + noop buildinputs.tag required:true→ 空 jobsrequired:false+ref_type==tagnpm run build,纯脚本包无脚本会挂--if-presentinstallHostBootstrapstub DataAdaptercreateHttpDataAdapter可注入db-routes错误路径混用{success:false}jsonV2Fail({ok:false})paths.ROOT写死相对路径SFMC_ROOTdb.txrecorder 不回放 serverresultssuccess方言修复
pack:verify+ lock 纳入toolstools/package.json:main/bin/files/noopbuildnpm-publish.yml:空 jobs 门控 +build --if-presentdb-routesv2 失败信封验证
PUBLISH_TAG=@sfmc-bds/tools@v0.1.0 node tools/resolve-npm-publish-tag.mjs→ Version OKnpm run build -w @sfmc-bds/tools --if-present→ oknpm pack -w @sfmc-bds/tools --dry-run→ 21 filesdb-servernode --test:7/7SFMC_ROOT=$PWD node tools/check-ootb.mjs:10/10合入后操作
@sfmc-bds/tools@v0.1.0仍指向旧 commit:合入后请workflow_dispatch指定该 tag,或挪 tag 到含本修复的 commit 后重推关联