fix(wf@d52f8b5): 登记 @sfmc-bds/tools 发包 + npm-publish 空 jobs 门控 - #27
Merged
Tanya7z merged 2 commits intoJul 22, 2026
Merged
Conversation
npm-publish 在 tag @sfmc-bds/tools@v0.1.0 上因清单未知包失败 (run 29926464473)。补登记、纳入 workspace,并修正 main/files/build。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
- inputs.tag 非 required + ref_type==tag,避免改 workflow 的 branch push 空 jobs - build 使用 --if-present,兼容无编译步骤的纯 mjs 包 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Tanya7z
marked this pull request as ready for review
July 22, 2026 14:05
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
workflow npm-publish 在 tag
@sfmc-bds/tools@v0.1.0(main@d52f8b5publish dev tools)失败:ootb 同 commit 已绿。
审查结论(DRY / OCP / DIP / LSP / Demeter)
@sfmc-bds/tools未写入NPM_PUBLISH_PACKAGES权威表tools未进 rootworkspaces,即便登记后npm publish -w仍会挂inputs.tag required:true→ 改 workflow 的 branch push 空 jobsrequired:false+ref_type==tag(吸收 #25 CI 部分)main: check-ootb.js不存在;无build会让 publish 下一步失败.mjs+ noop build;workflowbuild --if-presentpack:verify未含 toolspaths.mjs仍假定 monorepo 布局(ROOT=../..),npm 安装后需SFMC_ROOT修复
tools/lib/npm-publish-packages.mjs增加@sfmc-bds/toolspack:verify纳入 tools;更新 locktools/package.json:main→check-ootb.mjs,files含lib,noopbuildnpm-publish.yml:空 jobs 门控 +build --if-present验证
合入后操作
@sfmc-bds/tools@v0.1.0仍指向旧 commit:合入后请workflow_dispatch指定该 tag,或挪 tag 到含本修复的 commit 后重推。关联