Skip to content

fix(push@507a2bd): npm-publish 空 jobs + HttpDB DataAdapter / db-routes 信封 - #24

Closed
cursor[bot] wants to merge 3 commits into
mainfrom
cursor/bc-2b746ba4-cc49-4cce-aed3-45fd2891b396-c7f3
Closed

fix(push@507a2bd): npm-publish 空 jobs + HttpDB DataAdapter / db-routes 信封#24
cursor[bot] wants to merge 3 commits into
mainfrom
cursor/bc-2b746ba4-cc49-4cce-aed3-45fd2891b396-c7f3

Conversation

@cursor

@cursor cursor Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

背景

审查 main@507a2bd(仅简化 npm-publish skip 文案)。ootb 绿。

合入 #23 后多次出现 npm-publish 空 jobs / workflow file issue 失败(如 29922880511):改 workflow 的 branch push 被 GHA 误评估,叠加 workflow_dispatch.inputs.tag: required: true → 解析期失败。

修复

CI(wf 失败)

  • inputs.tagrequired: false(空 tag 仍由 resolve-npm-publish-tag.mjs 拒绝)
  • publish job:if: workflow_dispatch || ref_type==tag,误触 branch push 为 skipped 而非空失败

SOLID

级别 原则
MAJOR DIP installHostBootstrap 默认 createHttpDataAdapterHttpDB.configure / dbServerUrl / dataAdapter 可替换
MAJOR LSP/DRY db-routes 错误路径统一 jsonV2Fail({ok:false})jsonV2Fail 支持 extra(如 step)

未改(需协议/平台设计)

  • LSP:db.tx recorder 仍不回放 server results
  • MINOR:平台 legacy 路由(modules/messages/config)仍 success 方言

验证

  • db-server node --test:7/7
  • SFMC_ROOT=$PWD node tools/check-ootb.mjs:9/9(CLI warn 跳过)
Open in Web View Automation 

cursoragent and others added 2 commits July 22, 2026 13:22
workflow_dispatch.inputs.tag 改为非 required,并给 publish job 加
tag/dispatch 门控,避免改 workflow 的 branch push 被 GHA 误评估后
出现空 jobs + "workflow file issue"(如 run 29922880511)。

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
- installHostBootstrap 默认注入 createHttpDataAdapter,可经
  dataAdapter / dbServerUrl 替换;HttpDB.configure 覆盖基址
- db-routes 错误路径统一 jsonV2Fail({ok:false}),支持 step extra

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
@Tanya7z
Tanya7z marked this pull request as ready for review July 22, 2026 13:36
@cursor

cursor Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@Tanya7z

Tanya7z commented Jul 22, 2026

Copy link
Copy Markdown
Member

new

@Tanya7z
Tanya7z deleted the cursor/bc-2b746ba4-cc49-4cce-aed3-45fd2891b396-c7f3 branch July 22, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants