Skip to content

Track smoke artifacts and configurable build inputs - #13083

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits into
masterfrom
bdu/smoke-test-artifact-inputs
Oct 29, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits into
masterfrom
bdu/smoke-test-artifact-inputs

Conversation

@bric3

@bric3 bric3 commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

What Does This Do

Track the built smoke application and additional files as test inputs. In particular, a more precise version tracking, using the release file.

This adds an inputs { ... } hook to the smoke-test DSL. Each application can register named input providers through the regular Gradle's TaskInputs API. The Spring and Quarkus native applications use it to track their GraalVM release metadata.

Motivation

Smoke tests received application paths through JVM arguments, but the files were absent from their declared inputs! This didn't properly track the application and could allow build-cache reuse of a changed smoke test app.

Moreover application configurations also need to declare the external tools that affect their nested builds.

Additional Notes

Contributor Checklist

@bric3 bric3 added tag: ai generated Largely based on code generated by an AI or LLM comp: tooling Build & Tooling type: bug fix Bug fix tag: no release notes Changes to exclude from release notes labels Oct 27, 2026 — with ChatGPT Codex Connector
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.46% (-0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4f1ca88 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.99 s 13.94 s [-0.5%; +1.2%] (no difference)
startup:insecure-bank:tracing:Agent 12.93 s 13.01 s [-1.4%; +0.2%] (no difference)
startup:petclinic:appsec:Agent 17.17 s 17.09 s [-0.3%; +1.2%] (no difference)
startup:petclinic:iast:Agent 16.29 s 17.08 s [-8.9%; -0.4%] (maybe better)
startup:petclinic:profiling:Agent 16.91 s 17.01 s [-1.8%; +0.7%] (no difference)
startup:petclinic:sca:Agent 17.10 s 16.98 s [-0.1%; +1.5%] (no difference)
startup:petclinic:tracing:Agent 16.29 s 16.11 s [+0.2%; +2.1%] (maybe worse)

Commit: 4f1ca88d · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3 bric3 changed the title Track smoke application contents in test inputs Track smoke artifacts and GraalVM metadata in task inputs Oct 28, 2026
@bric3 bric3 changed the title Track smoke artifacts and GraalVM metadata in task inputs Track smoke artifacts and configurable build inputs Oct 28, 2026
@bric3
bric3 added this pull request to stack #13103 October 28, 2026 10:00
@bric3
bric3 marked this pull request as ready for review October 28, 2026 12:11
@bric3
bric3 requested a review from a team as a code owner October 28, 2026 12:11
@bric3
bric3 requested review from amarziali and sarahchen6 and removed request for a team October 28, 2026 12:11
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T12:15:06.710217Z a4b628d Draft marked ready
🔒 Security Review ✅ Completed 2026-10-28T12:15:23.025316Z a4b628d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

No reportable defect was identified in the artifact dependency wiring or lazy GraalVM metadata inputs. Confidence is limited to source inspection.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit a4b628d

@sarahchen6 sarahchen6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. left minor comment

@bric3
bric3 removed this pull request from stack #13103 October 29, 2026 11:06
@bric3
bric3 added this pull request to stack #13119 October 29, 2026 11:07
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 2e9435f into master Oct 29, 2026
623 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the bdu/smoke-test-artifact-inputs branch October 29, 2026 14:14
@github-actions github-actions Bot added this to the 1.69.0 milestone Oct 29, 2026
@bric3 bric3 mentioned this pull request Oct 29, 2026
5 of 7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants