Repository navigation
Conversation
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
05f7779 to
0bf02b2
Compare
0bf02b2 to
9e094be
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The lazy identity provider and task-input wiring match the documented behavior: tracked GitLab CI inputs require a nonblank builder identity, while local consumers receive an empty map.
🤖 Bits Code Review · Commit 92ccd7b
There was a problem hiding this comment.
More details
Cache invalidation depends on CI changing ciBuilderImage when builder contents change; republishing an unchanged tag remains an explicitly documented limitation.
🤖 Bits Code Review · Commit fc1a646
b0ce14d to
95c51de
Compare
95c51de to
48e74b4
Compare
There was a problem hiding this comment.
More details
The cache identity covers configured builder-version and platform changes, but intentionally cannot detect an image republished under the same tag.
🤖 Bits Code Review · Commit 95c51de
PerfectSlayer
left a comment
There was a problem hiding this comment.
❔ question: Dumb question: why not apply it by default rather than having to pick and maintain the comment about image tool used for every module that includes it?
I'm pretty sure this comment won't be tracked / updated properly over time 😓
|
@PerfectSlayer Fair question! The rationale is to not over fingerprint inputs either. Adding more input reduce reusability of the cached outputs. |
There was a problem hiding this comment.
More details
The configured builder identity reaches selected task fingerprints and native-smoke producer inputs, while local builds remain independent of the CI property. Execution behavior was not validated.
🤖 Bits Code Review · Commit 5ed610c
What Does This Do
Include the CI builder image identity in cache keys for Git integration tests, native profiling tests and native smoke builds. The opt-in convention applies to CI Visibility, ddprof, and the Spring and Quarkus native smoke modules.
When
CI=true, it adds the identity toTest,ExecandJavaExecinputs. Native smoke producers declare the same input explicitly. CI suppliesciBuilderImagethrough one global variable derived from the existing builder repository and version prefix; local builds require no configuration.Motivation
JVM fingerprints do not identify Git, native runtime libraries or the C compiler, linker and headers supplied by the image. Changing the configured builder version should invalidate results that depend on these components.
Additional Notes
Routine shell-command wrappers and CWS tests using dummy native requests keep their existing task inputs. Their basic command and memory assertions do not justify invalidating results on every image change.
The identity contains the opaque
ciBuilderImagevalue, operating system and architecture. Missing or blank values fail when a tracked CI task's inputs are queried. Outside CI, the provider returns an empty map.Republishing an image under the same tag leaves the configured identity unchanged. CI can later supply a content hash through the same property. Native builds also fingerprint GraalVM
releasecontents through #13083; compiler tasks keep Gradle's toolchain inputs.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue