Repository navigation
Apply builder image fingerprints to selected CI tasks - #13086
Conversation
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
78a0cba to
fad8b5d
Compare
fad8b5d to
5f75fd2
Compare
05f7779 to
0bf02b2
Compare
5f75fd2 to
8a97ea1
Compare
0bf02b2 to
9e094be
Compare
7380c83 to
1341e44
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1341e44 to
e8a7017
Compare
There was a problem hiding this comment.
More details
Configured builder-version changes enter the selected task fingerprints, including both native smoke builds. Republishing the same image tag remains outside this cache-invalidation scheme, as documented.
🤖 Bits Code Review · Commit 1341e44
| GRADLE_PLUGIN_PROXY: "https://depot-read-api-java.us1.ddbuild.io/magicmirror/magicmirror/@current/" | ||
| BUILDER_IMAGE_REPO: "registry.ddbuild.io/images/mirror/dd-trace-java-docker-build" # images are pinned in images/mirror.lock.yaml in the ddoghq/images repo | ||
| BUILDER_IMAGE_VERSION_PREFIX: "ci-" # use either an empty string (e.g. "") for latest images or a version followed by a hyphen (e.g. "ci-" or "123_merge-") | ||
| # shortcut: tag republishing is not detected; use a content hash when CI builds the image. |
There was a problem hiding this comment.
note: This is related to the task of building the build-image in this pipeline.
What Does This Do
Apply builder image fingerprints to seven projects whose tests and nested smoke builds consume image tools or native libraries. Supply
ciBuilderImagethrough one globalORG_GRADLE_PROJECT_ciBuilderImagevariable derived from the existing builder repository and version prefix.Motivation
Changing the configured builder version should invalidate affected test and native-build outputs alongside the existing JVM fingerprints.
Additional Notes
Confirmed consumers of builder image contents:
lsContainerInfoTestinvokesls -id.echo,cat,sleep,tailPortableCommandTest;ShellCommandExecutorTestinvokes the first three.ErpcTlsTestuses JNA native memory; CWS loads libc throughErpcTlsandErpc.Native builds already fingerprint the GraalVM
releasecontents through #13083. This PR adds the builder identity to test and native producer inputs. Compiler tasks keep Gradle's toolchain inputs.The value currently identifies the configured image version. Republishing an image under the same tag leaves it unchanged. CI can later supply the image content hash through the same property.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue