Skip to content

Apply builder image fingerprints to selected CI tasks - #13086

Merged
bric3 merged 2 commits into
bdu/ci-builder-inputsfrom
bdu/pin-ci-builder-images
Oct 29, 2026
Merged

bric3 merged 2 commits into
bdu/ci-builder-inputsfrom
bdu/pin-ci-builder-images

Conversation

@bric3

@bric3 bric3 commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

What Does This Do

Apply builder image fingerprints to seven projects whose tests and nested smoke builds consume image tools or native libraries. Supply ciBuilderImage through one global ORG_GRADLE_PROJECT_ciBuilderImage variable derived from the existing builder repository and version prefix.

Motivation

Changing the configured builder version should invalidate affected test and native-build outputs alongside the existing JVM fingerprints.

Additional Notes

Confirmed consumers of builder image contents:

Image contents Confirmed consumers
System ls ContainerInfoTest invokes ls -id.
echo, cat, sleep, tail PortableCommandTest; ShellCommandExecutorTest invokes the first three.
Native runtime / libc ErpcTlsTest uses JNA native memory; CWS loads libc through ErpcTls and Erpc.
libc variant ddprof controller tests load the bundled native profiler selected for the current libc variant.
GraalVM and native tools Spring and Quarkus smoke producers compile native executables in nested Gradle builds.

Native builds already fingerprint the GraalVM release contents through #13083. This PR adds the builder identity to test and native producer inputs. Compiler tasks keep Gradle's toolchain inputs.

The value currently identifies the configured image version. Republishing an image under the same tag leaves it unchanged. CI can later supply the image content hash through the same property.

Contributor Checklist

@bric3 bric3 added tag: ai generated Largely based on code generated by an AI or LLM comp: tooling Build & Tooling type: bug fix Bug fix tag: no release notes Changes to exclude from release notes labels Oct 27, 2026 — with ChatGPT Codex Connector
@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.47% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: fc1a646 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.99 s 13.90 s [-0.1%; +1.4%] (no difference)
startup:insecure-bank:tracing:Agent 12.93 s 13.03 s [-1.6%; +0.0%] (no difference)
startup:petclinic:appsec:Agent 17.74 s 17.47 s [+0.6%; +2.4%] (maybe worse)
startup:petclinic:iast:Agent 17.43 s 17.66 s [-2.3%; -0.3%] (maybe better)
startup:petclinic:profiling:Agent 17.06 s 17.36 s [-2.7%; -0.8%] (maybe better)
startup:petclinic:sca:Agent 17.62 s 17.48 s [-0.0%; +1.7%] (no difference)
startup:petclinic:tracing:Agent 16.60 s 16.81 s [-2.2%; -0.3%] (maybe better)

Commit: fc1a6466 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3
bric3 force-pushed the bdu/pin-ci-builder-images branch from 78a0cba to fad8b5d Compare October 28, 2026 07:51
@bric3 bric3 changed the title Pin CI builder images by digest Apply builder image fingerprints to selected CI tasks Oct 28, 2026
@bric3
bric3 added this pull request to stack #13099 October 28, 2026 08:02
@bric3
bric3 force-pushed the bdu/pin-ci-builder-images branch from fad8b5d to 5f75fd2 Compare October 28, 2026 09:12
@bric3
bric3 force-pushed the bdu/ci-builder-inputs branch from 05f7779 to 0bf02b2 Compare October 28, 2026 09:52
@bric3
bric3 force-pushed the bdu/pin-ci-builder-images branch from 5f75fd2 to 8a97ea1 Compare October 28, 2026 09:56
@bric3
bric3 removed this pull request from stack #13099 October 28, 2026 09:59
@bric3
bric3 added this pull request to stack #13103 October 28, 2026 10:00
@bric3
bric3 force-pushed the bdu/ci-builder-inputs branch from 0bf02b2 to 9e094be Compare October 28, 2026 10:41
@bric3
bric3 force-pushed the bdu/pin-ci-builder-images branch 6 times, most recently from 7380c83 to 1341e44 Compare October 28, 2026 13:26
@bric3
bric3 marked this pull request as ready for review October 28, 2026 13:29
@bric3
bric3 requested review from a team as code owners October 28, 2026 13:29
@bric3
bric3 requested review from AlexeyKuznetsov-DD and randomanderson and removed request for a team October 28, 2026 13:29
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T13:32:27.651641Z 1341e44 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-28T13:33:19.905059Z 1341e44 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@bric3
bric3 requested a review from sarahchen6 October 28, 2026 13:30
@bric3
bric3 force-pushed the bdu/pin-ci-builder-images branch from 1341e44 to e8a7017 Compare October 28, 2026 13:31

@datadog-prod-us1-4 datadog-prod-us1-4 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

Configured builder-version changes enter the selected task fingerprints, including both native smoke builds. Republishing the same image tag remains outside this cache-invalidation scheme, as documented.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 1341e44

Comment thread .gitlab-ci.yml
GRADLE_PLUGIN_PROXY: "https://depot-read-api-java.us1.ddbuild.io/magicmirror/magicmirror/@current/"
BUILDER_IMAGE_REPO: "registry.ddbuild.io/images/mirror/dd-trace-java-docker-build" # images are pinned in images/mirror.lock.yaml in the ddoghq/images repo
BUILDER_IMAGE_VERSION_PREFIX: "ci-" # use either an empty string (e.g. "") for latest images or a version followed by a hyphen (e.g. "ci-" or "123_merge-")
# shortcut: tag republishing is not detected; use a content hash when CI builds the image.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: This is related to the task of building the build-image in this pipeline.

@sarahchen6 sarahchen6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@bric3
bric3 removed this pull request from stack #13103 October 29, 2026 11:06
@bric3
bric3 merged commit fc1a646 into bdu/ci-builder-inputs Oct 29, 2026
620 of 623 checks passed
@bric3
bric3 deleted the bdu/pin-ci-builder-images branch October 29, 2026 11:06
@bric3 bric3 mentioned this pull request Oct 29, 2026
5 of 7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants