Repository navigation
On Call overhaul: four clear jobs, Refer inside Contacts, no link list on Now - #3480
Conversation
Tabs are Now, Contacts and Playbook, with the Handbook first in More. Contacts gains a Refer tab (the old Refer address lands there in the current work mode). Now drops the seven-link footer, keeps the shift lists inside the shift tools card, and shows each usual number. The Handbook holds Who's who and the Pocket card and folds its crisis lines like every other page. Handover and Check these get the normal band, and Check these becomes a compact list. No number, crisis line, step or caveat wording changed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKaduMkUZJSfvFH9L1yWuz
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
Merging this PR will improve performance by 29.47%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | answer-ranking: rankAnswerEvidence 40 results |
32.1 ms | 24.8 ms | +29.47% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/work-mode-simplify-plan-0hr9zi (96bb948) with main (c92fb84)
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
Chips stacked unevenly at 320px; one row per situation reads cleaner. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKaduMkUZJSfvFH9L1yWuz
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKaduMkUZJSfvFH9L1yWuz
codeant-ai
Bot
added
the
size:L
PR Summary by QodoSimplify On Call navigation and move Refer into Contacts
AI Description
Diagram
High-Level Assessment
Files changed (25)
|
Qodo FixerNo findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR. |
Code Review by Qodo
No findings for this group No findings for this group No findings for this group Resolved findings 1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
CodeAnt Nitpicks4 code suggestions1. This tab is added without a new-work-mode gate, so classic mode also exposes the embedded Refer experience even though its Refer route remains standalone.Incomplete implementation · 2.
|
CodeAnt PR Risk: Low Risk
Assessed commit: |
… follow ?show= - A search that matches only a referral no longer reads as no results. - Refer shows the public crisis lines, since it shows no hospital numbers. - The chosen tab follows and updates ?show=, so refresh and the old Refer redirect agree. - Refer, Who's who and Pocket card search words move to Contacts and the Handbook. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKaduMkUZJSfvFH9L1yWuz
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de4afa83c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Also import ReactNode explicitly in the shift tools card. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKaduMkUZJSfvFH9L1yWuz
|
Code review by qodo was updated up to the latest commit 4ac98aa |
|
Code review by qodo was updated up to the latest commit f08178e |
…al' opens Refer Classic readers keep the old People tabs and the standalone Refer page. Work search lists Refer on its own, linking the old address, which opens the Refer tab in the new work mode. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKaduMkUZJSfvFH9L1yWuz
Code Review ✅ Approved 1 closed / 1 findings🟡 Medium risk · Folding signed-out Handbook crisis lines behind “More crisis lines” may make non-000 emergency options less immediately visible. Restructures On Call into four jobs, with Refer moved inside Contacts as a tab so one search covers numbers and referrals, and the Now page's link list removed. Resolved a referral count that ignored the Refer team filter, so the empty-state message now shows correctly. No open issues remain.
✅ 1 closed✅ Edge Case: Referral count ignores the Refer team filter, hiding 'Nothing matches'
Review coverage🤖 Auto-approval Approved 📋 Rules No rules evaluated 🧪 Functional validation Not enabled · Set up OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
Code review by qodo was updated up to the latest commit 96bb948 |
User description
Requested by Josh · project thread
Summary
Before: On Call spread one job over eleven pages. The tabs were Now, People and Refer, and More held 12 entries. Refer was a near-empty page of its own. Now ended with "More for this shift", a seven-link list (My shifts, Pocket card, Calendar, Shift lists, Systems down, First night, On site), most of which belonged to other areas. Your usual showed a round phone icon and a label but no number. The Handbook still showed all three crisis lines in full when signed out. Handover and Check these dropped the band and showed their title twice. Check these drew a separate card for every entry, each with a greyed-out button in demo mode. The page-actions button on Playbook was labelled "More", which sat right under the band's More tab.
After: four jobs. Now is the shift. Contacts (was People) covers who and where, with a new Refer tab beside Hospital, Outside and Mine, so one search covers numbers and referrals. Playbook is what to do. The Handbook (first in More, so it joins the tab row when there is room) is how the hospital works, and now also holds Who's who and the Pocket card. More is down to seven: Handbook, Starting here, Handover, Who's on, Help, Check these and Manage service (editors only). Now has no link list. The shift lists sit in one card with Log a call and Handover, and each usual number is printed under its name. The Handbook folds the crisis lines to 000 plus "More crisis lines", like every other page. Handover and Check these get the normal band and one Back. Check these is one compact list. The page-actions button reads "Options".
Old addresses still work.
/on-call/referopens Contacts on its Refer tab in the current work mode, and the classic work mode keeps its own Refer page.How: navigation and layout only. Refer's lists became
OnCallReferSections, which both the old Refer page and the Contacts tab render.NowFooteris now unused but kept under the 30-day dead-code rule.Areas touched: Personal practice, App experience, Knowledge and records
Verification
tests/on-call*,tests/work-frame*, route, work-search, navigation and sitemap suite:Tests 2890 passed (2890).tsc --noEmitclean, eslint clean on changed files, prettier clean.Risk and rollout
Notes
🤖 Generated with Claude Code
https://claude.ai/code/session_01TKaduMkUZJSfvFH9L1yWuz
Generated by Claude Code
Summary by cubic
Restructures On Call into four clear jobs: Now shows the shift, Contacts (was People) covers who and where, Playbook is what to do, and the Handbook is how the hospital works. Refer moves inside Contacts as a Refer tab, so one search covers numbers and referrals. The old
/on-call/referaddress redirects to that tab in the new work mode and keeps its own page, with the original People tabs, for classic readers. Work search lists Refer on its own, so searching "referral" opens the routes rather than Hospital. The Refer tab keeps the public crisis lines, and a search that matches only a referral counts as a result. A search on Refer covers every team, so the count matches Contacts, while the team filter applies only to browsing.Now drops the seven-link "More for this shift" list, keeps the shift lists with Log a call and Handover in one card, and prints each usual number under its name. The Handbook now holds Who's who and the Pocket card, and folds its signed-out crisis lines to 000 plus "More crisis lines". Handover and Check these get the normal band and one Back, Check these becomes a single compact list, the who-to-call situations become one grouped list of rows instead of chips, and the page-actions button is renamed "Options". No phone number, crisis line, escalation step, caveat, or source wording changed.
OnCallReferSections, rendered by both the old Refer page and the Contacts tab.?show=, so refresh reopens the same tab and the redirect lands on it.NowFooteris unused but kept under the 30-day dead-code rule.Written for commit 96bb948. Summary will update on new commits.
CodeAnt-AI Description
Organize On Call around Now, Contacts, Playbook and the Handbook
What Changed
Impact
✅ One search for numbers and referrals✅ Usual call numbers visible at a glance✅ Fewer links on the shift overview💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.