Repository navigation
Work mode: simplify CPD Summary and Admin Today - #3481
Conversation
…up, draft) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0168BzqKVmcXcnjkYGCYbq3s
CPD Summary: What's left shows its top three then See all in End of year; the copy and reflection chips and About this year go (they repeated What's left and the hero); today's hours join the hero kicker; target source stays as a quiet footnote; progress bar tracks read on white. Admin Today: the three count cards become a strip at the top of Coming up; Work and leave and Pay and hours leave Today (all still in More). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0168BzqKVmcXcnjkYGCYbq3s
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
Merging this PR will degrade performance by 23.09%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ |
answer-ranking: rankAnswerEvidence 40 results |
24.8 ms | 32.2 ms | -23.09% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/work-cpd-summary-admin-today-2ank8b (c509a8a) with main (76f0eb3)
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0168BzqKVmcXcnjkYGCYbq3s
🤖 CodeAnt AI — Review Status
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
codeant-ai
Bot
added
the
size:L
qodo-code-review
Bot
added
🕐 40+ Minutes
and removed
size:L
PR Summary by QodoSimplify CPD Summary and Admin Today
AI Description
Diagram
High-Level Assessment
Files changed (13)
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 902635c6a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Code Review by Qodo
No findings for this group No findings for this group No findings for this group Resolved findings 1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
- Show today's hours without a target - Show year dates in empty summaries
Qodo Fixer✅ Committed (3) · ☑ Fixed (3) Commits pushed directly to this PR — no separate fix PR opened. Process — 3 fixed
|
The no-target summary (screen 10) still printed the bare year after About this year was removed, so weeks left and today's hours vanished there. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0168BzqKVmcXcnjkYGCYbq3s
CodeAnt Nitpicks1 code suggestion1. During loading, the count placeholders are under Needs you on the left; after this change, the counts appear inside Coming up on the right, visibly shifting the layout when data loads.Css layout issue · |
CodeAnt PR Risk: Low Risk
Assessed commit: |
…day-2ank8b' into claude/work-cpd-summary-admin-today-2ank8b
The automated fix added a second today's-hours line beside the one in the kicker, and put Overtime back on Admin Today, which the approved plan moved to More. Keep its visible year dates on the empty summary. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0168BzqKVmcXcnjkYGCYbq3s
…abelled The counts moved into Coming up, so the loading shape no longer shows a count row under Needs you. An empty closed year keeps its visible label even with Year dates off. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0168BzqKVmcXcnjkYGCYbq3s
|
Code review by qodo was updated up to the latest commit 5e047db |
…ry-admin-today-2ank8b
|
No code changes since the last review — review skipped |
Code Review ✅ Approved 1 closed / 1 findings🟡 Medium risk · Showing only three CPD items and moving Admin Today counts into Coming up could make follow-up needs less immediately visible. Simplifies the CPD Summary and Admin Today pages: CPD Summary now shows the top three "What's left" items with a "See all" link, today's hours move into the hero kicker, and Admin Today folds its counts into a slim strip above Coming up. The hero kicker change that broke an exact-text Playwright check has been resolved. No open issues found.
✅ 1 closed✅ Bug: Hero kicker now adds "· 1 h today", breaking exact-text Playwright check
Review coverage🤖 Auto-approval Approved 📋 Rules No rules evaluated 🧪 Functional validation Not enabled · Set up OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
CodSpeed flags one regressed benchmark on c509a8a, but this PR is not the cause. The benchmarks in Generated by Claude Code |
Requested by Josh · project thread
Summary
Before: CPD Summary listed all eight "What's left" items, then repeated the copy count as a "Records to tidy" chip and the weeks left and today's hours in "About this year". Admin Today showed the same dates four ways (hero, Needs you, three count cards, Coming up), then Work and leave and Pay and hours links.
After: CPD Summary shows the top three items, then "See all 8 in End of year". Today's hours join the hero kicker, and the target source stays as a quiet footnote. Admin Today folds the three counts into a slim strip at the top of Coming up, and keeps Today about dates. Contract, Leave, the starter pack and Overtime stay in More.
How: removals and one regrouping on two pages, built from the 12 Oct Work mode simplify plan after Josh approved the mockup ("Build it"). Polish: the progress bar tracks in What's left now use the mode's soft tint, so they read on white. Customise's "Year dates" and "Logged today" switches now control the hero's weeks left and today's hours. The two retired Admin components are kept under the 30 day rule, marked for deletion from 11 Nov 2026.
Areas touched: Personal practice
Verification
npm run test:focusedover the changed files:Test Files 39 passed (39),Tests 520 passed (520). ESLint on changed files (0 warnings) andtsc --noEmitclean. Screenshots from local Chromium at 390 px and 1440 px with example data. Browser suites are left to CI.Risk and rollout
Notes
🤖 Generated with Claude Code
https://claude.ai/code/session_0168BzqKVmcXcnjkYGCYbq3s
Generated by Claude Code