[BigSimmo]

User description

Summary

• Before: on a computer, On Call Now was lopsided. The left column stopped after Right now, while the right column ran about 400 px further with Who do I call now?, the shift tools and the crisis lines.
• After: Who do I call now? sits in the left column under your numbers and Right now. The shift tools and crisis lines fill the right column, so the two columns end at about the same height. On a phone it now follows Right now and any hospital alerts or "needs you" rows, ahead of the team list.
• How: the Who do I call now? list moves from the right-hand slot of the shared Today layout into the left-hand slot. No component, wording, number, crisis line or caveat changed. This is the last On Call layout item from the 12 Oct Work mode simplify plan, following On Call overhaul: four clear jobs, Refer inside Contacts, no link list on Now #3480.

Areas touched: Personal practice

Verification

• Checks run:
  • npx vitest run tests/on-call-now.dom.test.tsx tests/on-call-home.dom.test.tsx: 61 passed. The safety-order tests still hold, and the Now test now pins Who do I call now before the team list, in the left column.
  • npx playwright test tests/ui-on-call-now.spec.ts --project=chromium against the local demo server: 13 passed. The new phone and computer column check passed in light and dark. This was a focused browser proof only; the full suite is left to CI.
  • Prettier, eslint and typecheck are clean.

Risk and rollout

• Risk: low. Only the order of existing On Call Now sections changes. It is safety-adjacent because Now is the on-call page, but no clinical content changes.
• Rollback: revert this PR.
• Provider or production effects: None.

Notes

The emergency route and the public crisis lines keep their positions.

🤖 Generated with Claude Code

https://claude.ai/code/session_01TKaduMkUZJSfvFH9L1yWuz

---

CodeAnt-AI Description

Move call guidance beside escalation numbers on On Call Now

What Changed

• “Who do I call now?” now appears with the numbers and “Right now” in the left column on desktop, while shift tools and crisis lines stay in the right column.
• On phones, call guidance appears after “Right now” and before the team list.

Impact

✅ Balanced On Call columns on desktop
✅ Call guidance beside escalation numbers
✅ Call guidance before the team list on phones

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

[codeant-ai]

🤖 CodeAnt AI — Review Status

Status	Commit	Started (UTC)	Finished (UTC)
✅ Incremental review completed	f074400	Oct 12, 2026 · 11:04	11:05
✅ Reviewed your PR	cb77e5b	Oct 12, 2026 · 08:54	08:59

[greptile-apps]

BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

[codeant-ai]

---

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 66ae896b-4959-47f3-9e80-efffd4858be2

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-12T08:57:32.444662Z	cb77e5b	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[claude]

Claude encountered an error after 2s —— View job

---

I'll analyze this and get back to you.

[qodo-code-review]

PR Summary by Qodo

Balance the On Call Now columns by moving Who to Call

✨ Enhancement 🕐 10-20 Minutes

AI Description

• Move “Who do I call now?” beneath the left-column numbers and Right now section.
• Balance the desktop columns and place calling guidance before the team list on phones.
• Preserve the emergency route, crisis lines, and clinical content.

Diagram

graph TD
  Shell["Today shell"] --> Left["Now and needs"] --> Who["Who to call"]
  Shell --> Right["Coming up"] --> Tools["Shift tools"] --> Crisis["Crisis lines"]

Loading

High-Level Assessment

Moving the existing component between Today shell slots is the smallest way to balance desktop columns while establishing the intended phone order. Changing the shared shell or duplicating content would add scope without benefiting this layout change.

Files changed (1) +4 / -1

Enhancement (1) +4 / -1

on-call-home.tsxPlace calling guidance in the left Today column +4/-1

Place calling guidance in the left Today column

• Moves NowWhoToCall from the Coming-up slot to the Needs-you slot after immediate guidance. Its data and content stay the same; desktop column placement and phone reading order change.

src/components/on-call/on-call-home.tsx

[codeant-ai]

🏁 CodeAnt Quality Gate Results

Commit: f074400f
Scan Time: 2026-10-12 11:05:36 UTC

✅ Overall Status: PASSED

Quality Gate Details

Quality Gate	Status	Details
Secrets	✅ PASSED	0 secrets found
Duplicate Code	✅ PASSED	0.0% duplicated
SAST	✅ PASSED	No security issues
Bugs	✅ PASSED	Rating S: No bugs
IAC	✅ PASSED	No IAC issues

View Full Results

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

No findings for this group

No findings for this group

No findings for this group

Resolved findings

1. Column move can regress unnoticed ✓ Resolved

Description

The updated OnCallHomeLive placement moves NowWhoToCall between layout slots, but the focused
tests only assert the hospital, emergency route, Right now, and shift-tools order. A future slot or
responsive-layout change could move the call guidance back below the team content without failing
the current DOM or browser checks.

Code

src/components/on-call/on-call-home.tsx[R386-389]

+              {/* Who to call sits in the left column with the numbers, so on a computer the
+                  numbers and escalation balance the shift tools on the right (Work mode
+                  simplify plan, 12 Oct 2026). */}
+              <NowWhoToCall situations={situations} reminder={pinnedReminder?.title ?? null} />

Relevance

●●● Strong

Recent On Call precedents accept adding focused browser or regression tests for layout and
navigation behavior.

PR-#3467
PR-#3225

ⓘ Recommendations generated based on similar findings in past PRs

Evidence

The changed code relocates the section between TodayShell slots, while the existing browser order
assertion covers only hospital, emergency, Right now, and shift tools; it does not protect the newly
claimed Who do I call now placement.

src/components/on-call/on-call-home.tsx[386-389]
tests/ui-on-call-now.spec.ts[33-55]
Skill: testing-review

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The `NowWhoToCall` section was moved into the shared Needs you slot to change its mobile and desktop position, but the existing tests do not assert that new ordering or column assignment.

## Fix Focus Areas
- src/components/on-call/on-call-home.tsx[368-410]
- tests/on-call-home.dom.test.tsx[240-260]
- tests/ui-on-call-now.spec.ts[33-55]

## Recommended Fix
Add focused assertions that `NowWhoToCall` appears before the team section in the rendered mobile DOM and that it remains in the left desktop column while shift tools and crisis lines remain in the right column. Extend the browser proof to exercise both a phone-sized viewport and a desktop-sized viewport, checking the relevant test IDs or bounding-box order without depending on exact pixel heights.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

Context sources

✅ Compliance rules (platform): 9 rules

✅ Skills: testing-review

✅ Cross-repo context — repo relationships

✅ REVIEW.md

Review mode: Auto: 🚀 Fast: Localized test-only change with one straightforward layout assertion path.

Tip of the day

💡 Did you know, you can commit Qodo's fix in one click with committable suggestions (GitHub & GitLab)

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Previous reviews

Review updated until commit f074400

Results up to commit cb77e5b 🚀 Fast

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

No findings for this group

No findings for this group

No findings for this group

Resolved findings

1. Column move can regress unnoticed ✓ Resolved

Description

The updated OnCallHomeLive placement moves NowWhoToCall between layout slots, but the focused
tests only assert the hospital, emergency route, Right now, and shift-tools order. A future slot or
responsive-layout change could move the call guidance back below the team content without failing
the current DOM or browser checks.

Code

src/components/on-call/on-call-home.tsx[R386-389]

+              {/* Who to call sits in the left column with the numbers, so on a computer the
+                  numbers and escalation balance the shift tools on the right (Work mode
+                  simplify plan, 12 Oct 2026). */}
+              <NowWhoToCall situations={situations} reminder={pinnedReminder?.title ?? null} />

Relevance

●●● Strong

Recent On Call precedents accept adding focused browser or regression tests for layout and
navigation behavior.

PR-#3467
PR-#3225

ⓘ Recommendations generated based on similar findings in past PRs

Evidence

The changed code relocates the section between TodayShell slots, while the existing browser order
assertion covers only hospital, emergency, Right now, and shift tools; it does not protect the newly
claimed Who do I call now placement.

src/components/on-call/on-call-home.tsx[386-389]
tests/ui-on-call-now.spec.ts[33-55]
Skill: testing-review

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The `NowWhoToCall` section was moved into the shared Needs you slot to change its mobile and desktop position, but the existing tests do not assert that new ordering or column assignment.

## Fix Focus Areas
- src/components/on-call/on-call-home.tsx[368-410]
- tests/on-call-home.dom.test.tsx[240-260]
- tests/ui-on-call-now.spec.ts[33-55]

## Recommended Fix
Add focused assertions that `NowWhoToCall` appears before the team section in the rendered mobile DOM and that it remains in the left desktop column while shift tools and crisis lines remain in the right column. Extend the browser proof to exercise both a phone-sized viewport and a desktop-sized viewport, checking the relevant test IDs or bounding-box order without depending on exact pixel heights.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

[gitar-bot]

Gitar has auto-approved this PR (configure)

[codspeed]

Merging this PR will not alter performance

⚠️ 2 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

• catalog-search: rankCatalogRecords 400 records
• answer-ranking: rankAnswerEvidence 40 results

ℹ️ 1 benchmark has no flame graph

The flamegraph could not be generated because too much time was spent in runtime internals, making the visualization not useful for performance analysis.

• medication-entities: medicationEntityMatchesInText

✅ 8 untouched benchmarks

---

_{Comparing claude/work-mode-simplify-plan-0hr9zi (f074400) with main (b5d3a99)}

[BigSimmo]

Qodo's finding about the column move regressing unnoticed is fixed in f14c1d6. The Now DOM test now pins Who do I call now before the team list and inside the left (act) column, with the shift tools in the right (ahead) column.

---

Generated by Claude Code

[gitar-bot]

Gitar has auto-approved this PR (configure)

[qodo-code-review]

Qodo Fixer

✅ Committed (1) · ☑ Fixed (1)

Commits pushed directly to this PR — no separate fix PR opened.

Process — 1 fixed

• ☑ Fixed: Column move can regress unnoticed

[qodo-code-review]

Code review by qodo was updated up to the latest commit f14c1d6

[gitar-bot]

Gitar has auto-approved this PR (configure)

[codeant-ai]

CodeAnt Nitpicks

1 code suggestion

1. NowWhoToCall follows NowShiftClock, HospitalShiftUpdates, and NowNeedsYou, so on phones it does not appear directly after “Right now” as promised.

Incomplete implementation · src/components/on-call/on-call-home.tsx:389

[codeant-ai]

CodeAnt PR Risk: Low Risk

• The PR appears safe to merge; it moves call guidance into the left column with the numbers while keeping shift tools on the right.
• Updated DOM and browser tests check the section order on phones and the intended column placement on desktop.

Assessed commit: f074400f3d94

[gitar-bot]

Gitar has auto-approved this PR (configure)

[qodo-code-review]

Code review by qodo was updated up to the latest commit 87f32f3

[qodo-code-review]

No code changes since the last review — review skipped

[gitar-bot]

Code Review ✅ Approved

🟡 Medium risk · Moving “Who do I call now?” into the left column changes how on-call users locate escalation guidance, which could slow finding it.

Moves the Who do I call now? list into the left column under your numbers and Right now on desktop, so the two On Call Now columns end at about the same height. On phones it now appears right after Right now, ahead of the team list. No open issues found.

Auto-approved: No blocking issues found.
Please see Auto-approve Docs for details on setting custom approval criteria.

Review coverage

🤖 Auto-approval Approved

📋 Rules No rules evaluated

🧪 Functional validation Not enabled · Set up

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}