Repository navigation
Desktop shell: one width per page kind, labelled Clinical rail - #3464
Conversation
…elled Clinical rail Work pages declare a reading or wide column and the band's title and tabs follow it, so the title lines up with the cards on desktop. Wide pages open out only from 1024px (tablet rule: phone at 768, desktop at 1024). Adds WorkWidePage, WorkSplit and WorkColumns for area threads. Desktop Clinical matches Work: labels under the rail icons, no Mode eyebrow in the pill, and the bell on tablets and desktop. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KHkbt7EPd1iS6ryTjtnzq2
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
PR Summary by QodoAlign Work page widths and label the desktop Clinical rail
AI Description
Diagram
High-Level Assessment
Files changed (23)
|
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
Merging this PR will improve performance by 10.51%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ ℹ️ | medication-entities: medicationEntityMatchesInText |
4.7 ms | 4.2 ms | +10.51% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/desktop-tablet-shell-05l4cq (cf7c880) with main (36c1ba3)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95abc8c5d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Code Review by Qodo
No findings for this group No findings for this group No findings for this group Resolved findings 1.
|
CodeAnt Nitpicks6 code suggestions1. When a landscape safe-area inset exceeds 1rem, this fixed 2rem allowance is smaller than the actual side padding, narrowing the band content and breaking alignment with page cards.Css layout issue · 2. When the current Clinical item is hovered, this equally specific later rule overrides its active tint, hiding the pill’s current-page highlight.Css layout issue · 3. This loads the shared controls module on clinical pages; its static
|
CodeAnt PR Risk: Medium Risk
Assessed commit: |
Team staffing, Sick for tomorrow, the Term evidence folder, CPD Home and the CV, and Open shifts Log and Week board drew a second back link under the band. WorkPageBack draws it in the top bar's left button instead and claims the slot, so the bar never shows two. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KHkbt7EPd1iS6ryTjtnzq2
|
Code review by qodo was updated up to the latest commit 0d4a2ee |
Both lazy header pieces now share one loader, so the header names the module once, as the bundle guard expects. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KHkbt7EPd1iS6ryTjtnzq2
|
Code review by qodo was updated up to the latest commit bd3f90b |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KHkbt7EPd1iS6ryTjtnzq2
…-shell-05l4cq # Conflicts: # tests/cme-applications-cv-page.dom.test.tsx
|
Code review by qodo was updated up to the latest commit dd948dc |
Demo Clinical pages on desktop were mounting the notification centre on idle, which pushed desktop /documents/search blocking time past its Lighthouse budget. The count still loads on hover, focus or tap. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KHkbt7EPd1iS6ryTjtnzq2
Code Review ✅ Approved 1 closed / 1 findings🟡 Medium risk · Adding a Clinical bell that reads notifications while signed in and changing widths across Work pages could trigger unexpected feed reads or disrupt layouts. Aligns Work page widths so band titles and tabs line up with content, and updates desktop Clinical rail labels, pill, and bell placement. No open issues found. The open-shift log form and Alerts settings finding was closed without a fix and remains at its current width.
✅ 1 closedClosed: Bug: Open-shift log form and Alerts settings marked wide, not reading
Review coverage🤖 Auto-approval Approved 📋 Rules No rules evaluated 🧪 Functional validation Not enabled · Set up OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
Code review by qodo was updated up to the latest commit cf7c880 |
Keeps the folder pieces the merged Term page borrows, takes main's top-bar Back for the former standalone folder page, and rewrites the old in-page back-link test as a check that the page draws only that one Back. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUW1LDKaPwpthKXaE6oeb6
User description
Requested by Josh · project thread
Summary
Before: on desktop, Work pages used three different widths (720, 1024 and 1280 px) while the band's title always sat in a 720 px column, so on Swaps, Team, On Call, Admin Today, Teaching and Open shifts the title did not line up with the cards. Desktop Clinical had an icon-only rail, a "Mode" label in the pill and no bell.
After: each Work page is either a reading page (45rem) or a wide page (64rem from 1024 px), and the band's title and tabs follow the page, so they line up. Below 1024 px every page stays the single phone column (tablet rule: phone at 768, desktop at 1024). Desktop and tablet Clinical show a name under every rail icon in the work rail's style, the pill reads like the phone's and Work's (no "Mode" label), and the bell sits in the header. Phones are unchanged.
How:
data-page-widthon page containers and abody:has()rule in work-mode.css set one--work-colfor band and body, so the server render is already right. The shared page shell marks itself wide inside a work area. Newwork-desktop-layout.tsxgives area pagesWorkWidePage,WorkSplit(list beside record, sticky list from 1024 px) andWorkColumns. Recorded as C9 in docs/design-system/DECISIONS.md.Verification
npm run test:focusedover the changed files:Test Files 138 passed (138),Tests 1796 passed (1796).tsc --noEmitclean; eslint clean on changed files.Risk and rollout
Notes
public/sw.js, no RAG ranking files.🤖 Generated with Claude Code
https://claude.ai/code/session_01KHkbt7EPd1iS6ryTjtnzq2
Generated by Claude Code
Summary by cubic
Work pages now use one column width per page kind so the band's title and tabs line up with the page content, and desktop Clinical matches Work's shell: labelled rail icons, no "Mode" eyebrow, and a bell that reads the feed on idle only for signed-in readers.
WorkWidePage,WorkSplitandWorkColumnsopen the wide layouts from 1024px, while posting and log forms keep reading width.narrowincluded — counts as wide, sincemax-w-readingalready is the wide column.Rollout
Written for commit cf7c880. Summary will update on new commits.
CodeAnt-AI Description
Align work pages and clarify Clinical navigation
What Changed
Impact
✅ Aligned work-page titles and content✅ Clearer Clinical rail navigation✅ Clinical notifications visible on tablets and desktop💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Summary by Gitar
WorkPageBack, not as a second link under the bandThis will update automatically on new commits.