Repository navigation
Clinical results feel instant: row placeholders, quiet Also matches, catalogue warm-up - #3496
Conversation
…hes, catalogue warm-up - Medication and Documents results show rows shaped like results (aria-busy on the results region) instead of a loading sentence or spinner over an empty page. - The Also matches strip is no longer drawn while it is still searching; it fills in under the main results once it has matches, and never shows a Searching row. - The first medication request of a submitted search goes without the 250 ms typing debounce; later query changes are still debounced. - Opening the Medication home warms its results chunk and the local catalogue route (no query text, nothing model-backed); Documents warms its results chunk only. Display timing only: which results appear and their order are unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Mws6schjKQbpCQqQzPMKSL
…laceholder bars Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Mws6schjKQbpCQqQzPMKSL
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
Merging this PR will improve performance by ×2.5
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ |
medication-entities: medicationEntityMatchesInText |
11.5 ms | 4.6 ms | ×2.5 |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/site-instant-results-xk2j9i (dcb387e) with main (a754fb8)
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
The zero-delay first request no longer fires as an anonymous call while the session is still loading; the resolved request still goes at once. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Mws6schjKQbpCQqQzPMKSL
The Also matches strip now mounts only once its lookup answers, so its header could land after the main rows settled and differ between runs. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Mws6schjKQbpCQqQzPMKSL
|
Full browser suite on this draft (run 38260466446): Chromium, Firefox, desktop Safari and iPad all passed. The only failures are iPhone Safari jobs (mobile-webkit 5/5, mobile-pwa-standalone 3/5, 4/5, 5/5), and each failing test is one that also fails on unrelated PRs today and on main's iPhone backlog (ledger #9Z197J): Generated by Claude Code |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
codeant-ai
Bot
added
the
size:L
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
PR Summary by QodoMake clinical search loading feel faster
AI Description
Diagram
High-Level Assessment
Files changed (13)
|
Qodo FixerNo findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR. |
Code Review by Qodo
No findings for this group 1. Record searches appear idle to readers
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
|
Plan monthly usage limit reached ↗ |
…t the pending arm Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Mws6schjKQbpCQqQzPMKSL
qodo-code-review
Bot
added
🔴 Large blast radius
and removed
🟠 Medium blast radius
labels
|
Code review by qodo was updated up to the latest commit e466399 |
…p so the count is announced Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Mws6schjKQbpCQqQzPMKSL
|
Code review by qodo was updated up to the latest commit 67bf944 |
…o a cached count is still announced Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Mws6schjKQbpCQqQzPMKSL
|
Code review by qodo was updated up to the latest commit f5ca834 |
codeant-ai
Bot
added
size:XL
|
No code changes since the last review — review skipped |
Code Review ✅ Approved 2 closed / 2 findings🟡 Medium risk · Changing clinical search request timing and gating related matches could leave results delayed or incomplete-looking if asynchronous states diverge. Adds result-shaped loading placeholders for Medication and Documents, keeps "Also matches" hidden until cross-mode lookups finish, and preloads search code on home-page open without any data request. Resolved the first-request auth race and restored the screen-reader announcement for the Also matches count. No open issues found. ✅ 2 closed✅ Bug: Zero-delay first request fires before auth resolves, then re-debounces
✅ Bug: Also-matches live region now mounts pre-filled, so the count may not be announced
VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Approved OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
User description
Requested by Josh · project thread
Summary
Site recommendations 12 Oct 2026, item 6. [CLINICAL search display only; Josh asked on 12 Oct for these drafts to be sent live once the full browser suite was checked]
Before: after pressing search on Medication, the page showed "Searching..." and "Loading medication catalogue..." over an empty page, and the "Also matches" strip kept saying "Searching..." after the main results had arrived. The first search also waited a 250 ms typing pause.
After: Medication and Documents show grey placeholder rows shaped like real results while loading (one named loading status for screen readers); Also matches stays out of view until every mode's matches are in, then appears below the results; the first request after Enter goes out at once; opening the Medication or Documents home preloads the results code (no data request, no query text, nothing paid or AI-backed).
How: new
ResultRowsPlaceholderanduseModeResultsWarmup;use-medication-catalog,medication-prescribing-workspace,universal-search-also-matches,document-search-results,answer-statusupdated.Areas touched: App experience, Design system (plus 1 file not yet placed in any area)
RAG impact: no retrieval behaviour change — only when results render; result content and order untouched. None of the changed files match
ragRankingPatterns.Screenshots:
/mnt/project-files/site-recommendations-2026-10-12/built/instant-results/in the project files (loading moment and settled, 390 light and dark, 1440, 320).Verification
npm run test:focusedon the changed files (after the review fixes): medication workspace and instant-results DOM tests passnpm run check:design-system-contract: exit 0Dev-server timings (machine shared and loaded, indicative only): Medication Enter to first row about 2.0 s before, about 1.7 s after; other modes within noise.
Risk and rollout
Notes
🤖 Generated with Claude Code
https://claude.ai/code/session_01Mws6schjKQbpCQqQzPMKSL
CodeAnt-AI Description
Show clinical search results sooner with clearer loading states
What Changed
Impact
✅ Clearer medication and document loading✅ No typing-delay wait on the first medication search✅ No background search when opening a mode💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.