Repository navigation
CPD on desktop: Summary in two columns, Log filters shown once - #3465
Conversation
From 1024px the CPD Summary puts the year, To log and What's left on the left, and the dates and the year's details on the right. The Log page becomes a wide page, its side column holds every filter so the chip row over the list steps aside, the column's chips wrap instead of being cut off, and the Log button sits over the list. Phones are unchanged. The Summary's links to the year-end page now say End of year. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JZNXNqu4ZWvQwW613xMf1P
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
PR Summary by QodoImprove CPD desktop Summary and Log layouts
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
Merging this PR will degrade performance by 23.07%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ |
answer-ranking: rankAnswerEvidence 40 results |
24.8 ms | 32.2 ms | -23.07% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/cpd-tidy-9jh19q (6a95716) with main (4393497)
Code Review by Qodo
No findings for this group No findings for this group No findings for this group Resolved findings 1.
|
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JZNXNqu4ZWvQwW613xMf1P
CodeAnt Nitpicks1 code suggestion1. At desktop,
|
CodeAnt PR Risk: Low Risk
Assessed commit: |
…PsychSift into claude/cpd-tidy-9jh19q
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b07fad7f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Code review by qodo was updated up to the latest commit a8867f6 |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JZNXNqu4ZWvQwW613xMf1P
|
Code review by qodo was updated up to the latest commit c651081 |
|
CodSpeed Performance Analysis is red here, but the regression isn't from this PR. Its benchmarks live in CodSpeed itself warns that this comparison ran across different runtime environments. There's no fix to port, and I can't re-run this external check from here, so I'm leaving it as it stands and will keep watching the PR's required checks. Generated by Claude Code |
…menu The phone menu change (#3466) added Psychiatry to the pinned rail and took Tools out, but this second expectation still listed the old rail. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JZNXNqu4ZWvQwW613xMf1P
|
Production UI critical failed on Main carries the same stale line, and no fix PR exists yet, so I've ported the one-line expectation update here in 48b81f2. Once main contains it, this change becomes a no-op. Generated by Claude Code |
|
Code review by qodo was updated up to the latest commit 48b81f2 |
The clinical sidebar took its counts reader from lazy-work-side-nav, which also loads the two-pane menu, which imports the clinical sidebar. The counts reader now lives in its own file, so the architecture test finds no loop. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JZNXNqu4ZWvQwW613xMf1P
|
Unit coverage partition (2) failed on 2ca4e90 at No fix exists on main yet, so I've ported one here in 0219a61. Generated by Claude Code |
|
Code review by qodo was updated up to the latest commit 0219a61 |
Main is red after #3466. This matches PR 3468 exactly so the two merge cleanly: the clinical sidebar loads its counts reader directly, breaking the import loop, and four browser tests follow the regrouped menu (Medication shortcut, tablet rail, active-tool routes, Tools out of the mode menu). It replaces this branch's earlier separate-file fix. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JZNXNqu4ZWvQwW613xMf1P
|
Production UI (3) on 0219a61 failed three more browser tests from #3466's menu change, none of them this PR's: the Medication shortcut, the tablet rail active-tool routes, and Tools leaving the mode menu. #3468 already fixes main for all of these and for the import loop, so 6a95716 ports #3468's changes exactly. It replaces my earlier separate-file loop fix, so the four touched files now match #3468 byte for byte and the two PRs will merge cleanly in either order. Generated by Claude Code |
Code Review ✅ Approved🟡 Medium risk · Desktop CPD layout relocates filters and actions, while sidebar counts load dynamically; regressions could hide controls or delay counts. Lays out CPD for desktop from 1024px: Summary uses two columns, and Log becomes a wide page with each filter shown once in its side column, wrapped chips, and the Log button over the list. Phones and upright tablets are unchanged. No issues found.
Review coverage🤖 Auto-approval Approved 📋 Rules No rules evaluated 🧪 Functional validation Not enabled · Set up OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
Code review by qodo was updated up to the latest commit 6a95716 |
User description
Summary
Before: on a desktop, CPD Summary was a single column using less than half the screen. Log showed every filter twice (a side column plus a chip row over the list), the side column's chips were cut off mid-word, and the floating Log button covered the filter column.
After: from 1024px wide, Summary puts the year card, To log and What's left on the left, and Also for you and About this year on the right. Log becomes a wide page. Its side column holds every filter, so the chip row steps aside, the column's chips wrap, and the Log button sits over the list. Phones and upright tablets are unchanged. Summary's links to the year-end page now say "End of year", matching its tab.
How: Summary uses the desktop frame's
WorkColumns(PR #3464). Log usesWorkWidePageon its Activities view. Three small unlayered rules inwork-mode.csshandle the chip row, the column chips and the dock offset at 1024px and up. Both changes come from the 11 Oct usefulness and layout audit (CPD items "Log page on desktop shows every filter twice" and "Summary on desktop in two columns").Areas touched: Personal practice, App experience
Verification
Tests 1197 passed (1197)Tests 131 passed (131)/cmeand/cme/logat 1440 px and 390 px (example data). Browser suites are left to CI.Risk and rollout
Notes
🤖 Generated with Claude Code
https://claude.ai/code/session_01JZNXNqu4ZWvQwW613xMf1P
Generated by Claude Code
Summary by cubic
Makes the CPD desktop layout use the wide screen from 1024px: the Summary sits in two columns, and the Log shows each filter once instead of twice.
Written for commit 6a95716. Summary will update on new commits.
CodeAnt-AI Description
Arrange the CPD summary and log for desktop screens
What Changed
Impact
✅ Two-column CPD summary on desktop✅ One set of log filters on desktop✅ Readable filter labels and unobstructed log actions💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.