Skip to content

CPD on desktop: Summary in two columns, Log filters shown once - #3465

Merged
gitar-bot[bot] merged 9 commits into
mainfrom
claude/cpd-tidy-9jh19q
Oct 11, 2026
Merged

gitar-bot[bot] merged 9 commits into
mainfrom
claude/cpd-tidy-9jh19q

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

User description

Summary

Before: on a desktop, CPD Summary was a single column using less than half the screen. Log showed every filter twice (a side column plus a chip row over the list), the side column's chips were cut off mid-word, and the floating Log button covered the filter column.

After: from 1024px wide, Summary puts the year card, To log and What's left on the left, and Also for you and About this year on the right. Log becomes a wide page. Its side column holds every filter, so the chip row steps aside, the column's chips wrap, and the Log button sits over the list. Phones and upright tablets are unchanged. Summary's links to the year-end page now say "End of year", matching its tab.

How: Summary uses the desktop frame's WorkColumns (PR #3464). Log uses WorkWidePage on its Activities view. Three small unlayered rules in work-mode.css handle the chip row, the column chips and the dock offset at 1024px and up. Both changes come from the 11 Oct usefulness and layout audit (CPD items "Log page on desktop shows every filter twice" and "Summary on desktop in two columns").

Areas touched: Personal practice, App experience

Verification

  • Checks run:
    • CPD unit and DOM tests, plus admin-wording and route-reachability: Tests 1197 passed (1197)
    • Design-system and overlay CSS contract tests: Tests 131 passed (131)
    • Internal typecheck clean; eslint clean on the changed files; prettier check passes
    • Container Chromium screenshots of /cme and /cme/log at 1440 px and 390 px (example data). Browser suites are left to CI.

Risk and rollout

  • Risk: layout only, from 1024px. There are no data, clinical or auth changes.
  • Rollback: revert this PR.
  • Provider or production effects: None.

Notes

  • The Summary dock sits under the left column on desktop, so the Log button is not stretched across the screen.

🤖 Generated with Claude Code

https://claude.ai/code/session_01JZNXNqu4ZWvQwW613xMf1P

Generated by Claude Code


Summary by cubic

Makes the CPD desktop layout use the wide screen from 1024px: the Summary sits in two columns, and the Log shows each filter once instead of twice.

  • Summary puts the year, To log, and What's left on the left; Also for you and About this year on the right. The grid collapses back to one column when the right side is empty.
  • Log becomes a wide page; its side column holds every filter, the chip row over the list is hidden, chips wrap instead of being cut off, and the Log button sits over the list.
  • Summary links to the year-end page now say "End of year" instead of "Report".
  • Splits the side-counts reader into its own file to break the import loop between the clinical sidebar and the two-pane menu.
  • Updates the UI tests for the regrouped mode menu: Medication opens via its pinned shortcut, the tablet rail lists Psychiatry instead of Tools, Tools leaves the mode menu, and the active-tool route checks narrow to the collapsed sidebar.
  • Phones and upright tablets are unchanged.

Written for commit 6a95716. Summary will update on new commits.

View guided diff Turn on auto-fix


CodeAnt-AI Description

Arrange the CPD summary and log for desktop screens

What Changed

  • From 1024px, the CPD summary places the year and outstanding items on the left, with dates and year details on the right.
  • The desktop Log page shows filters in a sidebar instead of repeating them above the list. Sidebar filters wrap, and the action button sits over the list.
  • Year-review links now say “End of year”. Phone layouts are unchanged.

Impact

✅ Two-column CPD summary on desktop
✅ One set of log filters on desktop
✅ Readable filter labels and unobstructed log actions

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

From 1024px the CPD Summary puts the year, To log and What's left on the
left, and the dates and the year's details on the right. The Log page
becomes a wide page, its side column holds every filter so the chip row
over the list steps aside, the column's chips wrap instead of being cut
off, and the Log button sits over the list. Phones are unchanged. The
Summary's links to the year-end page now say End of year.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JZNXNqu4ZWvQwW613xMf1P
@codeant-ai

codeant-ai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Incremental review completed 2ca4e90 Oct 11, 2026 · 12:46 12:47
✅ Reviewed your PR 8b07fad Oct 11, 2026 · 10:51 10:55

@codeant-ai

codeant-ai Bot commented Oct 11, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@supabase

supabase Bot commented Oct 11, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T10:56:12.556386Z 8b07fad PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: ef27963f-b80f-4030-b7df-94ad16e66122

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@claude

claude Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Claude encountered an error after 2s —— View job


I'll analyze this and get back to you.

@codeant-ai codeant-ai Bot added the size:M This PR changes 30-99 lines, ignoring generated files label Oct 11, 2026
@qodo-code-review qodo-code-review Bot added 🕐 20-40 Minutes and removed size:M This PR changes 30-99 lines, ignoring generated files labels Oct 11, 2026
@qodo-code-review

Copy link
Copy Markdown
Contributor

PR Summary by Qodo

Improve CPD desktop Summary and Log layouts

✨ Enhancement 🕐 20-40 Minutes

Grey Divider

AI Description

• Arrange the CPD Summary in two columns from 1024px while preserving mobile reading order.
• Widen the Log, show filters once, wrap sidebar chips, and keep its action dock over the list.
• Rename Summary links to match the “End of year” tab.
Diagram

graph TD
  Frame["Work frame"] --> Summary["CPD Summary"] --> Columns["WorkColumns"] --> Styles["Responsive CSS"]
  Frame --> Log["CPD Log"] --> Wide["WorkWidePage"] --> Styles
Loading
High-Level Assessment

Using the existing WorkColumns and WorkWidePage components keeps page widths consistent with the desktop frame. A CPD-specific layout wrapper would duplicate that behavior without a clear benefit.

Files changed (4) +71 / -23

Enhancement (4) +71 / -23
work-mode.cssAdd responsive column and Log filter presentation rules +26/-0

Add responsive column and Log filter presentation rules

• Hides empty WorkColumns children. From 1024px, wraps chips in the Log filter column, hides the duplicate chip row, and offsets the Log dock toward the activity list.

src/app/work-mode.css

cme-dashboard-whats-left.tsxRename the year-check link +1/-1

Rename the year-check link

• Changes the What’s left link text from “Report” to “End of year” to match the destination tab.

src/components/cme/cme-dashboard-whats-left.tsx

cme-dashboard.tsxArrange the CPD Summary in responsive columns +24/-18

Arrange the CPD Summary in responsive columns

• Replaces WorkBody with WorkColumns, placing the year, logging, and remaining-work content on the left and supplementary content on the right at desktop widths. Renames the fallback year-check row to “End of year.”

src/components/cme/cme-dashboard.tsx

cme-log-page.tsxWiden Log activities and avoid duplicate desktop filters +20/-4

Widen Log activities and avoid duplicate desktop filters

• Uses WorkWidePage for the Activities view while keeping To finish in WorkBody. Marks the desktop filter column, duplicate chip row, and activity dock for responsive styling.

src/components/cme/cme-log-page.tsx

@codeant-ai

codeant-ai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

🏁 CodeAnt Quality Gate Results

Commit: 6a957164
Scan Time: 2026-10-11 13:33:31 UTC

✅ Overall Status: PASSED

Quality Gate Details

Quality Gate Status Details
Secrets ✅ PASSED 0 secrets found
Duplicate Code ✅ PASSED 0.0% duplicated
SAST ✅ PASSED No security issues
Bugs ✅ PASSED Rating S: No bugs
IAC ✅ PASSED No IAC issues

View Full Results

@codspeed

codspeed Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 23.07%

⚠️ 4 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

ℹ️ 1 benchmark has no flame graph

The flamegraph could not be generated because too much time was spent in runtime internals, making the visualization not useful for performance analysis.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 7 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ ⚠️ answer-ranking: rankAnswerEvidence 40 results 24.8 ms 32.2 ms -23.07%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing claude/cpd-tidy-9jh19q (6a95716) with main (4393497)

Open in CodSpeed

@gitar-bot
gitar-bot Bot enabled auto-merge (squash) October 11, 2026 10:52
gitar-bot[bot]
gitar-bot Bot previously approved these changes Oct 11, 2026

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR (configure)

@qodo-code-review

qodo-code-review Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Action required

No findings for this group


Remediation recommended

No findings for this group


Informational

No findings for this group

Grey Divider


Resolved findings

1. The Log button moves to an empty column ✓ Resolved
Description
The .work-columns > :empty rule removes the dashboard’s empty right-hand wrapper from grid layout
without changing the two-column grid. When someone keeps “What’s left” but hides the other optional
sections, the dock becomes the second grid item and appears to the right of the Summary while the
Summary remains half-width.
Code

src/app/work-mode.css[R239-240]

+.work-columns > :empty {
+  display: none;
Relevance

●●● Strong

Specific empty-state grid placement bug contradicts the stated desktop layout intent; similar Work
layout defects were accepted.

PR-#3464
PR-#3365

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The dashboard always renders a right-hand wrapper before {dock}. With an existing target and
logged entries, showWhatsLeft can be true; the other right-hand sections can be absent when their
modules are hidden, there is no training position or upcoming application, and byCategory is null.
The new :empty rule then removes that wrapper from layout, but the desktop grid still has two
tracks, so automatic placement puts the dock in the second track.

src/components/cme/cme-dashboard.tsx[663-682]
src/components/cme/cme-dashboard.tsx[574-638]
src/components/cme/cme-dashboard.tsx[300-301]
src/lib/cme/module-order.ts[17-26]
src/app/work-mode.css[238-265]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
When the Summary’s right-hand wrapper is empty, `:empty` removes it from the two-column grid and the Log dock takes its place.

## Fix Focus Areas
- src/app/work-mode.css[238-266]
- src/components/cme/cme-dashboard.tsx[665-682]

## Recommended Fix
When the right-hand Summary column is empty, use a single-column grid so the dock stays below the Summary and the remaining content uses the available width. Preserve the intended left-column dock placement when both columns have content.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Context sources
✅ Compliance rules (platform): 9 rules
✅ Skills: 4 invoked
  accessibility-review
  design-review
  code-quality-review
  testing-review
✅ Cross-repo context — repo relationships
✅ REVIEW.md
Review mode: Auto: 🚀 Fast: Localized lazy-loading refactor and targeted UI test updates avoid high-risk behavior.

Grey Divider

Tip of the day
💡 Did you know, you can tweak Display settings with a live preview to see your comment before it ships

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Previous reviews

Review updated until commit 6a95716 🚀 Fast

Results up to commit 8b07fad ⚖️ Balanced


🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)


Action required

No findings for this group


Remediation recommended

No findings for this group


Informational

No findings for this group


Resolved findings

1. The Log button moves to an empty column ✓ Resolved
Description
The .work-columns > :empty rule removes the dashboard’s empty right-hand wrapper from grid layout
without changing the two-column grid. When someone keeps “What’s left” but hides the other optional
sections, the dock becomes the second grid item and appears to the right of the Summary while the
Summary remains half-width.
Code

src/app/work-mode.css[R239-240]

+.work-columns > :empty {
+  display: none;
Relevance

●●● Strong

Specific empty-state grid placement bug contradicts the stated desktop layout intent; similar Work
layout defects were accepted.

PR-#3464
PR-#3365

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The dashboard always renders a right-hand wrapper before {dock}. With an existing target and
logged entries, showWhatsLeft can be true; the other right-hand sections can be absent when their
modules are hidden, there is no training position or upcoming application, and byCategory is null.
The new :empty rule then removes that wrapper from layout, but the desktop grid still has two
tracks, so automatic placement puts the dock in the second track.

src/components/cme/cme-dashboard.tsx[663-682]
src/components/cme/cme-dashboard.tsx[574-638]
src/components/cme/cme-dashboard.tsx[300-301]
src/lib/cme/module-order.ts[17-26]
src/app/work-mode.css[238-265]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
When the Summary’s right-hand wrapper is empty, `:empty` removes it from the two-column grid and the Log dock takes its place.

## Fix Focus Areas
- src/app/work-mode.css[238-266]
- src/components/cme/cme-dashboard.tsx[665-682]

## Recommended Fix
When the right-hand Summary column is empty, use a single-column grid so the dock stays below the Summary and the remaining content uses the available width. Preserve the intended left-column dock placement when both columns have content.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Results up to commit a8867f6 🚀 Fast


No changes from previous review

Results up to commit c651081 🚀 Fast


No changes from previous review

Results up to commit 48b81f2 🧠 Deep


No changes from previous review

Results up to commit 0219a61 🚀 Fast


No changes from previous review

Grey Divider

Qodo Logo

Comment thread src/app/work-mode.css Resolved
@qodo-code-review

Copy link
Copy Markdown
Contributor

Qodo Fixer

✅ Committed (1) · ☑ Fixed (1)

Grey Divider

Commits pushed directly to this PR — no separate fix PR opened.

Process — 1 fixed
  • ☑ Fixed: The Log button moves to an empty column

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JZNXNqu4ZWvQwW613xMf1P
@codeant-ai

codeant-ai Bot commented Oct 11, 2026

Copy link
Copy Markdown

CodeAnt Nitpicks

1 code suggestion

1. At desktop, WorkColumns has two tracks, so this third child auto-places in the first track and leaves the sticky action only half-width.

Css layout issue · src/components/cme/cme-dashboard.tsx:681

@codeant-ai

codeant-ai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

CodeAnt PR Risk: Low Risk

  • The PR appears safe to merge; the visible changes are limited to CME page layout and terminology.
  • At desktop widths, the year page uses two columns and the log keeps its filters in a sidebar while hiding duplicate chips.
  • The updated test checks that WorkColumns retains the safe-area clearance rule.

Assessed commit: 2ca4e905aa91

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8b07fad7f5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/components/cme/cme-dashboard.tsx Resolved
gitar-bot[bot]
gitar-bot Bot previously approved these changes Oct 11, 2026

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR (configure)

gitar-bot[bot]
gitar-bot Bot previously approved these changes Oct 11, 2026

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR (configure)

@qodo-code-review

Copy link
Copy Markdown
Contributor

Code review by qodo was updated up to the latest commit a8867f6

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JZNXNqu4ZWvQwW613xMf1P
gitar-bot[bot]
gitar-bot Bot previously approved these changes Oct 11, 2026

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR (configure)

@qodo-code-review

Copy link
Copy Markdown
Contributor

Code review by qodo was updated up to the latest commit c651081

Copy link
Copy Markdown
Owner Author

CodSpeed Performance Analysis is red here, but the regression isn't from this PR. Its benchmarks live in bench/clinical-core.bench.ts (answer ranking and medication entities). This PR changes only CPD layout: work-mode.css, three CPD components and one DOM test. None of that code is in the benchmarked paths.

CodSpeed itself warns that this comparison ran across different runtime environments. There's no fix to port, and I can't re-run this external check from here, so I'm leaving it as it stands and will keep watching the PR's required checks.


Generated by Claude Code

@codeant-ai codeant-ai Bot added the size:M This PR changes 30-99 lines, ignoring generated files label Oct 11, 2026
…menu

The phone menu change (#3466) added Psychiatry to the pinned rail and took
Tools out, but this second expectation still listed the old rail.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JZNXNqu4ZWvQwW613xMf1P

Copy link
Copy Markdown
Owner Author

Production UI critical failed on tests/ui-smoke.spec.ts:1571 ("tablet shows icon rail…"). This PR didn't cause it. The failure arrived with the main merge, from #3466. That change added Psychiatry to the pinned rail and dropped Tools, and it updated the first rail expectation in this test but missed the second one, which runs after Forms is pinned and moved up.

Main carries the same stale line, and no fix PR exists yet, so I've ported the one-line expectation update here in 48b81f2. Once main contains it, this change becomes a no-op.


Generated by Claude Code

gitar-bot[bot]
gitar-bot Bot previously approved these changes Oct 11, 2026

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR (configure)

@qodo-code-review

Copy link
Copy Markdown
Contributor

Code review by qodo was updated up to the latest commit 48b81f2

The clinical sidebar took its counts reader from lazy-work-side-nav, which
also loads the two-pane menu, which imports the clinical sidebar. The counts
reader now lives in its own file, so the architecture test finds no loop.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JZNXNqu4ZWvQwW613xMf1P

Copy link
Copy Markdown
Owner Author

Unit coverage partition (2) failed on 2ca4e90 at tests/architecture-boundaries.test.ts ("has no runtime import cycles"). This one also comes from #3466 on main, not from this PR. The loop runs ClinicalSidebar → lazy-work-side-nav → two-pane-side-menu → ClinicalSidebar.

No fix exists on main yet, so I've ported one here in 0219a61. LazyWorkSideCounts moves into its own lazy-work-side-counts.tsx, and lazy-work-side-nav re-exports it. ClinicalSidebar now imports it from the new file, so the loop is gone. The architecture test and the clinical menu drawer DOM test both pass locally.


Generated by Claude Code

gitar-bot[bot]
gitar-bot Bot previously approved these changes Oct 11, 2026

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR (configure)

@qodo-code-review

Copy link
Copy Markdown
Contributor

Code review by qodo was updated up to the latest commit 0219a61

Main is red after #3466. This matches PR 3468 exactly so the two merge
cleanly: the clinical sidebar loads its counts reader directly, breaking the
import loop, and four browser tests follow the regrouped menu (Medication
shortcut, tablet rail, active-tool routes, Tools out of the mode menu).
It replaces this branch's earlier separate-file fix.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JZNXNqu4ZWvQwW613xMf1P

Copy link
Copy Markdown
Owner Author

Production UI (3) on 0219a61 failed three more browser tests from #3466's menu change, none of them this PR's: the Medication shortcut, the tablet rail active-tool routes, and Tools leaving the mode menu. #3468 already fixes main for all of these and for the import loop, so 6a95716 ports #3468's changes exactly. It replaces my earlier separate-file loop fix, so the four touched files now match #3468 byte for byte and the two PRs will merge cleanly in either order.


Generated by Claude Code

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR (configure)

@gitar-bot

gitar-bot Bot commented Oct 11, 2026

Copy link
Copy Markdown
Contributor
Code Review ✅ Approved

🟡 Medium risk · Desktop CPD layout relocates filters and actions, while sidebar counts load dynamically; regressions could hide controls or delay counts.

Lays out CPD for desktop from 1024px: Summary uses two columns, and Log becomes a wide page with each filter shown once in its side column, wrapped chips, and the Log button over the list. Phones and upright tablets are unchanged. No issues found.

Auto-approved: No blocking issues found.
Please see Auto-approve Docs for details on setting custom approval criteria.

Review coverage

🤖 Auto-approval Approved

📋 Rules No rules evaluated

🧪 Functional validation Not enabled · Set up

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@qodo-code-review

Copy link
Copy Markdown
Contributor

Code review by qodo was updated up to the latest commit 6a95716

@gitar-bot
gitar-bot Bot merged commit e80d148 into main Oct 11, 2026
42 of 43 checks passed
@gitar-bot
gitar-bot Bot deleted the claude/cpd-tidy-9jh19q branch October 11, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔴 Large blast radius size:M This PR changes 30-99 lines, ignoring generated files 🕐 20-40 Minutes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants