Skip to content

tests: the stale-publish test waits for the announced move, not the first viewer line #2185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
santoshkumarradha merged 3 commits into from
Nov 2, 2026
Merged

tests: the stale-publish test waits for the announced move, not the first viewer line #2185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
257d7bd
tests: the stale-publish test waits for the announced move, not the f…
santoshkumarradha Nov 2, 2026
58d7ece
docs: change entry for this pull request
santoshkumarradha Nov 2, 2026
0c209b2
Merge remote-tracking branch 'origin/app/v3' into c40/stale-publish-test
santoshkumarradha Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/changes/unreleased/2185-stale-publish-test.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
kind: internal
title: The stale-publish test waits for the announced move, not the first viewer line
pr: 2185
surface: [chat]
---
5 changes: 4 additions & 1 deletion internal/syncsetup/drive_refusal_safety_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ func TestStalePublishRefusalMakesViewerAndNotifiesOnce(t *testing.T) {
}
h.block.set(false)
want := chatlist.Superseded(nameB)
waitFor(t, "A to become a viewer after stale publish", func() bool { _, viewer := a.drive.Viewer(); return viewer })
// The window refuses work at once, first with an unnamed line while the
// holder's name is read, and announces the move once pending saves have
// settled (#1971). The announcement is the settled state.
waitFor(t, "A to announce the move after stale publish", func() bool { return h.wall.has(want) })
if line, viewer := a.drive.Viewer(); !viewer || line != want {
t.Fatalf("viewer = %q, %v; want %q, true", line, viewer, want)
}
Expand Down