Skip to content

fix: require Node.js 22.23.4, 24.22.1 or 26.12.1 for the eMudhra intermediate CA compromise - #49

Merged
plum117 merged 1 commit into
webdriverio:mainfrom
plum117:fix/node-floor-emudhra
Oct 25, 2026
Merged

plum117 merged 1 commit into
webdriverio:mainfrom
plum117:fix/node-floor-emudhra

Conversation

@plum117

@plum117 plum117 commented Oct 25, 2026

Copy link
Copy Markdown
Collaborator

Fixes #48

Summary

Require the Node.js releases with the updated CA store for the eMudhra intermediate CA compromise ("ca-cert (eMudhra Intermediate CA Compromise) on 26.x, 24.x, 22.x" in the October 2026 security releases). Same range as webdriverio/webdriverio#16211.

"engines": { "node": ">=22.23.4 <23 || >=24.22.1 <25 || >=26.12.1" }
Place Change
engines.node (root, edgedriver, geckodriver, safaridriver) >=22.19.0 → the range above
ci.yml Push matrix ["22.19.0", 22, 24, 26] → the floor of each line ["22.23.4", "24.22.1", "26.12.1"]. The PR row stays 24 (the required check build (<os>, 24) keeps its name) with check-latest: true: a bare 24 took the runner cache (24.21.0) in webdriverio/webdriverio#16211
audit.yml, release.yml check-latest: true for .nvmrc
.agents/setup, .agents/resume Read the || range from package.json (they stripped a single >=)
README compatibility table, upgrade notes, package READMEs, AGENTS.md, driver-release and verify-driver skills New floors

Test plan

Command Node 22.23.4 Node 24.22.1
pnpm install --frozen-lockfile no engine warning no engine warning
pnpm run build ok ok
pnpm test 83 passed 83 passed
pnpm -r run check:pack No problems found (3 packages) No problems found (3 packages)

pnpm run test:lint: ok. npm install --engine-strict of the packed safaridriver tarball: Node 24.20.0 → EBADENGINE, exit 1; Node 24.22.1 → added, exit 0.

.agents/resume with each local Node:

Node 18.20.8, 20.20.2, 22.22.3, 24.15.0, 24.18.0, 24.20.0, 25.9.0, 26.3.1, 26.11.1 22.23.4, 24.22.1
Result Node x is not supported (package.json#engines: …) accepted
  • pnpm --filter <package> test
  • The e2e run or packed-tarball check that proves the change (see AGENTS.md): e2e left to CI (real browsers); packed-tarball check above

Release type

The driver-release skill lists "Raises engines" as major. WebdriverIO, expect-webdriverio and visual-testing shipped this floor as a minor version. A driver major (geckodriver 9, edgedriver 9, safaridriver 4) reaches WebdriverIO 10 users only after @wdio/utils widens its range. Which one to choose stays with the publishers.

@greptile-apps

greptile-apps Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Raises the Node.js requirements in the root and all three driver packages to >=22.23.4 <23 || >=24.22.1 <25 || >=26.12.1.

  • The driver packages now require updated Node.js releases on lines 22, 24, or 26.
  • Developer setup checks now accept the supported Node.js release windows.
  • Push CI runs builds at the supported Node.js floors.
  • Audit and release jobs now select the latest Node.js patch.

No actionable issues were found.

Acknowledged intent: plum117 explicitly chose minimum-version push jobs and left the release-type decision to the publishers.

Reviews (1) · Last reviewed commit: "fix: require Node.js 22.23.4, 24.22.1 or..." · Reviewed by Greptile

@plum117
plum117 merged commit 12e9db6 into webdriverio:main Oct 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require the Node.js releases with the eMudhra CA fix (22.23.4, 24.22.1, 26.12.1)

1 participant