Skip to content

fix: require Node.js 22.23.4, 24.22.1 or 26.12.1 for the eMudhra intermediate CA compromise - #120

Merged
plum117 merged 1 commit into
webdriverio:mainfrom
plum117:fix/node-floor-emudhra
Oct 25, 2026
Merged

plum117 merged 1 commit into
webdriverio:mainfrom
plum117:fix/node-floor-emudhra

Conversation

@plum117

@plum117 plum117 commented Oct 25, 2026

Copy link
Copy Markdown
Collaborator

Fixes #119

Require the Node.js releases with the updated CA store for the eMudhra intermediate CA compromise ("ca-cert (eMudhra Intermediate CA Compromise) on 26.x, 24.x, 22.x" in the October 2026 security releases). Same range as webdriverio/webdriverio#16211 and webdriverio/driver#49.

Place Change
Root engines.node ^22.22.2 || ^24.15.0 || >=26.0.0 → >=22.23.4 <23 || >=24.22.1 <25 || >=26.12.1
test.yml main matrix ["22.x", "24.x", "26.x"] → the floor of each line ["22.23.4", "24.22.1", "26.12.1"]; the PR row stays 24.x with check-latest: true. A bare 24 took the runner cache (24.21.0) in webdriverio/webdriverio#16211
publish.yml (3 jobs) check-latest: true on 24.x, so a release never builds on a 24.x below the floor

Not changed:

Place Reason
.cursor/Dockerfile (node:24-bookworm-slim) The tag already ships 24.22.1 (image of 2026-10-21)
packages/*/package.json They have no engines; adding one is a new constraint for users, so it is not part of this PR

How you tested

Command Node 22.23.4 Node 24.22.1
pnpm install --frozen-lockfile ok ok
pnpm run checks:all (compile, typechecks, unit, CLI examples) exit 0, 464 tests passed exit 0, 464 tests passed

pnpm 12.5.1 does not warn about the root range (checked with Node 24.20.0: install exit 0), so the root range informs contributors only.

@plum117
plum117 marked this pull request as ready for review October 25, 2026 17:20
@greptile-apps

greptile-apps Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Raises the root Node.js minimums and updates CI to match.

  • The monorepo's Node.js range starts at the updated releases.
  • Tests and releases use Node.js versions at or above the new floors.

Acknowledged scope from plum117: published packages remain without engines, the root range only informs contributors, and .cursor/Dockerfile stays unchanged because its tag already supplies the required release.

Reviews (1) · Last reviewed commit: "fix: require Node.js 22.23.4, 24.22.1 or..." · Reviewed by Greptile

@plum117
plum117 merged commit df0e518 into webdriverio:main Oct 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require the Node.js releases with the eMudhra CA fix (22.23.4, 24.22.1, 26.12.1)

1 participant