Repository navigation
fix: require Node.js 22.23.4, 24.22.1 or 26.12.1 for the eMudhra intermediate CA compromise - #120
Merged
Merged
Conversation
…rmediate CA compromise
plum117
marked this pull request as ready for review
October 25, 2026 17:20
[Medium impact] The PR appears safe to merge. SummaryRaises the root Node.js minimums and updates CI to match.
Acknowledged scope from Reviews (1) · Last reviewed commit: "fix: require Node.js 22.23.4, 24.22.1 or..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119
Require the Node.js releases with the updated CA store for the eMudhra intermediate CA compromise ("ca-cert (eMudhra Intermediate CA Compromise) on 26.x, 24.x, 22.x" in the October 2026 security releases). Same range as webdriverio/webdriverio#16211 and webdriverio/driver#49.
engines.node^22.22.2 || ^24.15.0 || >=26.0.0→>=22.23.4 <23 || >=24.22.1 <25 || >=26.12.1test.ymlmainmatrix["22.x", "24.x", "26.x"]→ the floor of each line["22.23.4", "24.22.1", "26.12.1"]; the PR row stays24.xwithcheck-latest: true. A bare24took the runner cache (24.21.0) in webdriverio/webdriverio#16211publish.yml(3 jobs)check-latest: trueon24.x, so a release never builds on a 24.x below the floorNot changed:
.cursor/Dockerfile(node:24-bookworm-slim)packages/*/package.jsonengines; adding one is a new constraint for users, so it is not part of this PRHow you tested
pnpm install --frozen-lockfilepnpm run checks:all(compile, typechecks, unit, CLI examples)pnpm 12.5.1 does not warn about the root range (checked with Node 24.20.0: install exit 0), so the root range informs contributors only.